From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCV2 14/28] android/hal-sco: Fix memory leak
Date: Wed, 4 Jun 2014 17:17:45 +0300 [thread overview]
Message-ID: <1401891479-11965-14-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1401891479-11965-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Release resampler on exit.
---
android/hal-sco.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/android/hal-sco.c b/android/hal-sco.c
index 42267e0..943a541 100644
--- a/android/hal-sco.c
+++ b/android/hal-sco.c
@@ -729,8 +729,10 @@ static void sco_close_output_stream(struct audio_hw_device *dev,
close_sco_socket();
- if (out->resampler)
+ if (out->resampler) {
release_resampler(out->resampler);
+ free(out->resample_buf);
+ }
free(out->cache);
free(out->downmix_buf);
--
1.8.3.2
next prev parent reply other threads:[~2014-06-04 14:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 14:17 [RFCV2 01/28] android/ipc: Add ipc_is_connected() check Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 02/28] android/handsfree: Connect SCO audio on demand Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 03/28] android/hal-sco: Use nanosleep for SCO synchronization Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 04/28] android/hal-sco: Fixes for unreliable mtu Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 05/28] android/hal-sco: Add SCO packet cache Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 06/28] android/hal-sco: Make use of config parameter Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 07/28] android/hal-sco: Implement open input stream Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 08/28] android/hal-sco: Check file descriptor >= 0 Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 09/28] android/hal-sco: Use global sco file descriptor Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 10/28] android/haltest: Add open/close input stream commands Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 11/28] android/haltest: Add read command Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 12/28] android/haltest: Add loop command Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 13/28] android/hal-sco: Make debug more readable Andrei Emeltchenko
2014-06-04 14:17 ` Andrei Emeltchenko [this message]
2014-06-04 14:17 ` [RFCV2 15/28] android/hal-sco: Implement read Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 16/28] android/haltest: Implement read to file Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 17/28] android/hal-sco: Connect SCO when opening input stream Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 18/28] android/haltest: Add sample rate parameter when opening audio streams Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 19/28] android/hal-sco: Skip resampling for output stream with 8k Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 20/28] android/hal-sco: Skip resampling for input of 8k Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 21/28] android/haltest: Correct check for similar buffer size Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 22/28] android/haltest: Add mono to stereo conversion for loopback Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 23/28] android/hal-sco: Choose buffer size Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 24/28] android/hal-sco: Add stream synchronization Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 25/28] android/haltest: Refactor stop and closing streams Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 26/28] android/hal-sco: Connect SCO audio on demand Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 27/28] android/hal-sco: Disconnect SCO audio on standby() Andrei Emeltchenko
2014-06-04 14:17 ` [RFCV2 28/28] android/handsfree: Refactor SCO audio connect sequence Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401891479-11965-14-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.