All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michal Kazior <michal.kazior@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC option 2] mac80211: introduce refcount for queue_stop_reasons
Date: Mon, 09 Jun 2014 12:21:19 +0300	[thread overview]
Message-ID: <1402305679.2004.37.camel@dubbel> (raw)
In-Reply-To: <1402305420.17674.0.camel@jlt4.sipsolutions.net>

On Mon, 2014-06-09 at 11:17 +0200, Johannes Berg wrote:
> On Mon, 2014-06-09 at 10:21 +0300, Luca Coelho wrote:
> 
> > > I think you need to make sure all stop/wake calls are balanced
> > > everywhere (including device drivers). Otherwise you risk breaking
> > > things silently in some cases.
> 
> > Checking this might be tricky, actually, since I think there are some
> > assumptions that stopping a queue that is already stopped is a NOP, but
> > now we add to the refcount...
> 
> I don't think we can force drivers to keep track of this, we'll have to
> keep the API without refcounting for drivers, I'd say.

Yeah, I was thinking in the same terms... Even for mac80211 might be a
bit tricky to do it.

Maybe I could keep the old APIs as is (ie. they wake the queues no
matter what the refcount is) and make the new
ieee80211_stop/wake_vif_queues() refcounted?

--
Luca.


  reply	other threads:[~2014-06-09  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 15:27 [RFC] mac80211: introduce refcount for queue_stop_reasons Luca Coelho
2014-06-06 18:46 ` [RFC option 2] " Luca Coelho
2014-06-09  5:34   ` Michal Kazior
2014-06-09  7:21     ` Luca Coelho
2014-06-09  9:17       ` Johannes Berg
2014-06-09  9:21         ` Luca Coelho [this message]
2014-06-09 14:52           ` Luca Coelho
2014-06-09 15:00             ` [RFC option 2 v2] " Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402305679.2004.37.camel@dubbel \
    --to=luca@coelho.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.