All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Per Hurtig <per.hurtig@kau.se>
Cc: "Nandita Dukkipati" <nanditad@google.com>,
	Netdev <netdev@vger.kernel.org>,
	"Anna Brunström" <anna.brunstrom@kau.se>,
	mohammad.rajiullah@kau.se, "Neal Cardwell" <ncardwell@google.com>,
	"Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] tcp: fixing TLP's FIN recovery
Date: Mon, 09 Jun 2014 09:15:02 -0700	[thread overview]
Message-ID: <1402330502.3645.378.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <5395D937.5060801@kau.se>

On Mon, 2014-06-09 at 17:56 +0200, Per Hurtig wrote:

> 
> Ok, I guess you mean that the retransmission was not fast enough? But 
> will the same not happen if the original FIN is not lost and triggers a 
> SACK (i.e., if the two last data segments are still lost)?

Yes, I'd like to understand why Nandita specifically added the original
test. In her tests, fast retransmit was not really effective.

Running packetdrill in a separate container gives me these interesting
counters :

# nstat
#kernel
IpInReceives                    4                  0.0
IpInDelivers                    4                  0.0
IpOutRequests                   5                  0.0
TcpPassiveOpens                 1                  0.0
TcpInSegs                       4                  0.0
TcpOutSegs                      10                 0.0
TcpRetransSegs                  2                  0.0
TcpExtTCPPureAcks               3                  0.0
TcpExtTCPSackRecovery           1                  0.0
TcpExtTCPFastRetrans            1                  0.0
TcpExtTCPLossProbes             1                  0.0
TcpExtTCPSackRecoveryFail       1                  0.0
TcpExtTCPSackShiftFallback      1                  0.0
TcpExtTCPRetransFail            4                  0.0   <<<< HERE >>>
TcpExtTCPOrigDataSent           9                  0.0
IpExtInOctets                   184                0.0
IpExtOutOctets                  9212               0.0
IpExtInNoECTPkts                4                  0.0

I guess we need to understand why the retransmit is in error.

I am investigating.

  reply	other threads:[~2014-06-09 16:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 18:46 tcp: fixing TLP's FIN recovery Per Hurtig
2014-06-06 19:07 ` Eric Dumazet
2014-06-07 11:10   ` [PATCH] " Per Hurtig
2014-06-07 13:56     ` Sergei Shtylyov
2014-06-07 14:34       ` Per Hurtig
2014-06-08  2:58         ` Eric Dumazet
2014-06-08  7:41           ` Per Hurtig
2014-06-08 16:35             ` Eric Dumazet
2014-06-09  7:04               ` Nandita Dukkipati
2014-06-09  7:02             ` Nandita Dukkipati
2014-06-09 13:13               ` Per Hurtig
2014-06-09 14:33                 ` Eric Dumazet
2014-06-09 14:39                   ` Eric Dumazet
2014-06-09 14:42                   ` Per Hurtig
2014-06-09 15:04                     ` Eric Dumazet
2014-06-09 15:56                       ` Per Hurtig
2014-06-09 16:15                         ` Eric Dumazet [this message]
2014-06-09 16:24                           ` Eric Dumazet
2014-06-09 18:33                             ` Eric Dumazet
2014-06-12 14:21               ` Weiping Pan
2014-06-12 14:32                 ` Eric Dumazet
2014-06-12 15:08                   ` [PATCH v2 1/1] " Per Hurtig
2014-06-12 15:28                     ` Eric Dumazet
2014-06-12 17:36                       ` Nandita Dukkipati
2014-06-12 17:46                         ` Neal Cardwell
2014-06-12 18:06                     ` David Miller
2014-10-07 15:03                       ` Josh Hunt
2014-10-07 20:17                         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402330502.3645.378.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=anna.brunstrom@kau.se \
    --cc=mohammad.rajiullah@kau.se \
    --cc=nanditad@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=per.hurtig@kau.se \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.