From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] net: xen-netback: include linux/vmalloc.h
 again
Date: Tue, 10 Jun 2014 09:52:36 +0100
Message-ID: <1402390356.29980.3.camel__18685.8855806806$1402390458$gmane$org@kazak.uk.xensource.com>
References: <5508988.K5Wec8A6hA@wuerfel>
	<20140610084454.GB28084@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1WuHnT-0004oi-8O
	for xen-devel@lists.xenproject.org; Tue, 10 Jun 2014 08:52:47 +0000
In-Reply-To: <20140610084454.GB28084@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Josh Boyer <jwboyer@fedoraproject.org>, Arnd Bergmann <arnd@arndb.de>, netdev@vger.kernel.org, xen-devel@lists.xenproject.org, "Andrew J.
	Bennieston" <andrew.bennieston@citrix.com>, David Miller <davem@davemloft.net>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:
> On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> > queue struct") added a use of vzalloc/vfree to interface.c, but
> > removed the #include <linux/vmalloc.h> statement at the same time,
> > which causes this build error:
> > 
> > drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> >   vfree(vif->queues);
> >   ^
> > cc1: some warnings being treated as errors
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Andrew J. Bennieston <andrew.bennieston@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> This didn't happen to me when I built it on x86 though. Just curious,
> did you build it on othet platform, say, ARM?

Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)

Ian.