From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v6 03/18] xl / libxl: push VCPU affinity pinning down to libxl Date: Tue, 10 Jun 2014 15:01:00 +0100 Message-ID: <1402408860.1250.136.camel@kazak.uk.xensource.com> References: <1402317809-26833-1-git-send-email-wei.liu2@citrix.com> <1402317809-26833-4-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402317809-26833-4-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Dario Faggioli , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2014-06-09 at 13:43 +0100, Wei Liu wrote: > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index 0ea0464..4765fb6 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -305,6 +305,7 @@ libxl_domain_build_info = > Struct("domain_build_info",[ > ("avail_vcpus", libxl_bitmap), > ("cpumap", libxl_bitmap), > ("nodemap", libxl_bitmap), > + ("vcpu_affinity", Array(libxl_bitmap, "num_vcpumaps")), Looking at one of Dario's patches I became confused about how this new field relates to the existing cpumap field. Am I right that the new field is just a per-vcpu version of the old (which only allows you to set the affinity of every vcpu together)? Can this relationship be mentioned in the commit message and/or comments please. I also wonder if the name could be changed to better reflect this relationship, but I can't actually think of a good name. cpumap_FOO where FOO has connotations of per-vcpu/listiness. I also just noticed that this change violates the following from idl.txt: idl.Array.len_var contains an idl.Field which is added to the parent idl.Aggregate and will contain the length of the array. The field MUST be named num_ARRAYNAME. Ian. > ("numa_placement", libxl_defbool), > ("tsc_mode", libxl_tsc_mode), > ("max_memkb", MemKB),