From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: leave rc6 enabled at suspend time v4 Date: Tue, 10 Jun 2014 17:41:49 +0300 Message-ID: <1402411309.7876.102.camel@intelbox> References: <1401910389-14722-1-git-send-email-jbarnes@virtuousgeek.org> <1401914722-17532-1-git-send-email-jbarnes@virtuousgeek.org> <1402407770.7876.72.camel@intelbox> <20140610135757.GN5821@phenom.ffwll.local> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1072050945==" Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CF136E6C8 for ; Tue, 10 Jun 2014 07:42:53 -0700 (PDT) In-Reply-To: <20140610135757.GN5821@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1072050945== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-ruS/Ym6ZWUCwCKKhnQSK" --=-ruS/Ym6ZWUCwCKKhnQSK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-06-10 at 15:57 +0200, Daniel Vetter wrote: > On Tue, Jun 10, 2014 at 04:42:50PM +0300, Imre Deak wrote: > > On Wed, 2014-06-04 at 13:45 -0700, Jesse Barnes wrote: > > > This allows the system to enter the lowest power mode during system f= reeze. > > >=20 > > > v2: delete force wake timer at suspend (Imre) > > > v3: add GT work suspend function (Imre) > > > v4: use uncore forcewake reset (Daniel) > > >=20 > > > Signed-off-by: Kristen Carlson Accardi > > > Signed-off-by: Jesse Barnes > > > --- > > > drivers/gpu/drm/i915/i915_drv.c | 4 ++-- > > > drivers/gpu/drm/i915/i915_drv.h | 1 + > > > drivers/gpu/drm/i915/intel_drv.h | 1 + > > > drivers/gpu/drm/i915/intel_pm.c | 20 ++++++++++++++++++++ > > > drivers/gpu/drm/i915/intel_uncore.c | 2 +- > > > 5 files changed, 25 insertions(+), 3 deletions(-) > > >=20 > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i= 915_drv.c > > > index 66c6ffb..7148eac 100644 > > > --- a/drivers/gpu/drm/i915/i915_drv.c > > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > > @@ -521,7 +521,7 @@ static int i915_drm_freeze(struct drm_device *dev= ) > > > drm_irq_uninstall(dev); > > > dev_priv->enable_hotplug_processing =3D false; > > > =20 > > > - intel_disable_gt_powersave(dev); > > > + intel_suspend_gt_powersave(dev); > >=20 > > I realized now that we actually do need to enable RC6 explicitly. If we > > get here right after runtime resume, the deferred RC6 enabling might be > > still pending and so RC6 might not be enabled. >=20 > Hm, for runtime pm we might schedule the delayed rps work with a 0 delay, > just to get the gpu going faster. Just an aside. > > Also some runtime pm vs system suspend tests in igt would be good if we > don't have them yet. And if we have them some analysis why this didn't > blow up in testing (and something to address that gap if feasible). To clarify the above is about the new functionality to enable deeper system wide power states. Atm, we don't have a bug related to the above runtime resume->system suspend sequence, since we explicitly disable gt power saving/RC6. For deeper power states we have to do the opposite and leave RC6 enabled and that's what I commented on. --Imre=20 --=-ruS/Ym6ZWUCwCKKhnQSK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTlxktAAoJEORIIAnNuWDF6mQH/A03JD2znkYiDtcEKpUovYHI vImskedgcftpC3bgYRzmhxeqn2g3JQVC/eCDA4Skhk9GjvGRf2Uv5VivwosreEL4 9oRk5zi5R6ZSsAdxTudcXagjBlO8CHOd8Q6IKXxNM3py6OGhUAsaCCOC5nYImY7W egtfNidmgc5Q92HUqc4Tj4MBIDFi+nPGQAvTPm3ObyK0QUtqdHtjFBW4FcTMwCna oEGxtfn1jWBJLwpr7ZfbB1dumyhbTZ2TrBcnRsfn1Wj8Cl27XkurrqQB+pv9X8VW KgicwUUeEqbC3liPfZFU50+YNe0mPTCK0LoY351bZ5l+AIZdP86ia2ZOltaWeTU= =NEQy -----END PGP SIGNATURE----- --=-ruS/Ym6ZWUCwCKKhnQSK-- --===============1072050945== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1072050945==--