From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 2/6] tools: arm: allocate superpages to
	guests.
Date: Wed, 11 Jun 2014 12:55:07 +0100
Message-ID: <1402487707.16332.18.camel@kazak.uk.xensource.com>
References: <1402394127.29980.52.camel@kazak.uk.xensource.com>
	<1402394278-9850-2-git-send-email-ian.campbell@citrix.com>
	<5396EACE.6070308@linaro.org>
	<1402413410.7541.5.camel@kazak.uk.xensource.com>
	<5398429B.3010101@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5398429B.3010101@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-06-11 at 12:50 +0100, Julien Grall wrote:
> On 06/10/2014 04:16 PM, Ian Campbell wrote:
> >>> +/*  >0: success, *nr_pfns set to number actually populated
> >>> + *   0: didn't try with this pfn shift (e.g. misaligned base etc)
> >>> + *  <0: ERROR
> >>> + */
> >>> +static int populate_one_size(struct xc_dom_image *dom, int pfn_shift,
> >>> +                             xen_pfn_t base_pfn, xen_pfn_t *nr_pfns)
> >>> +{
> >>> +    uint64_t mask = ((uint64_t)1<<(pfn_shift))-1;
> >>> +    uint64_t next_mask = ((uint64_t)1<<(LPAE_SHIFT))-1;
> >>> +    int nr, i, count = min_t(int, 1024*1024, *nr_pfns >> pfn_shift);
> >>
> >> Stupid question, where does come from the 1024*1024?
> > 
> > It was in the original as a backstop on allocsz. It would correspond to
> > 4GB worth of 4K page I suppose
> 
> Ah ok. I didn't pay attention about it.
> 
> > 
> >>> +    xen_pfn_t extents[count];
> >>
> >> If I follow the count definition, it's possible to allocate 1024*1024
> >> xen_pfn_t (about 8MB) on the stack.
> > 
> > userspace stack isn't all that precious but 8MB does seem a little
> > excessive. Previously this was using the already allocated host p2m so
> > it wasn't an issue, but that doesn't work for allocations of page >4K.
> > 
> > The tradeoff is that smaller batches mean it will take longer.
> > 
> > I don't think it would be unreasonable to reduce this to be e.g. 1GB
> > worth of entries (256*1024) or 2MB of stack.
> 
> It seems the default stack size is 8MB, I'm wondering if we can have
> some use case where this limit is smaller.

I think we effectively assume it is larger than any amount we would
practically use.

> Is there any issue to allocate this variable with malloc?

Just more book keeping code really.

Ian.