From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: [PATCH v4 3/6] drivers: cpuidle: implement OF based idle states infrastructure Date: Wed, 11 Jun 2014 17:18:37 +0100 Message-ID: <1402503520-8611-4-git-send-email-lorenzo.pieralisi@arm.com> References: <1402503520-8611-1-git-send-email-lorenzo.pieralisi@arm.com> Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1402503520-8611-1-git-send-email-lorenzo.pieralisi@arm.com> Sender: linux-pm-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: Lorenzo Pieralisi , Mark Rutland , Sudeep Holla , Catalin Marinas , Charles Garcia Tobin , Nicolas Pitre , Rob Herring , Grant Likely , Peter De Schrijver , Santosh Shilimkar , Daniel Lezcano , Amit Kucheria , Vincent Guittot , Antti Miettinen , Stephen Boyd , Kevin Hilman , Sebastian Capella , Tomasz Figa , Mark Brown , Paul Walmsley , Chander Kashyap List-Id: devicetree@vger.kernel.org On most common ARM systems, the low-power states a CPU can be put into are not discoverable in HW and require device tree bindings to describe power down suspend operations and idle states parameters. In order to enable DT based idle states and configure idle drivers, this patch implements the bulk infrastructure required to parse the device tree idle states bindings and initialize the corresponding CPUidle driver states data. Code that initializes idle states checks the CPU idle driver cpumask so that multiple CPU idle drivers can be initialized through it in the kernel. The CPU idle driver cpumask defines which idle states should be considered valid for the driver, ie idle states that are valid on a set of cpus the idle driver manages. Signed-off-by: Lorenzo Pieralisi --- drivers/cpuidle/Kconfig | 9 ++ drivers/cpuidle/Makefile | 1 + drivers/cpuidle/of_idle_states.c | 282 +++++++++++++++++++++++++++++++++++= ++++ drivers/cpuidle/of_idle_states.h | 8 ++ 4 files changed, 300 insertions(+) create mode 100644 drivers/cpuidle/of_idle_states.c create mode 100644 drivers/cpuidle/of_idle_states.h diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig index 1b96fb9..760ce20 100644 --- a/drivers/cpuidle/Kconfig +++ b/drivers/cpuidle/Kconfig @@ -30,6 +30,15 @@ config CPU_IDLE_GOV_MENU =09bool "Menu governor (for tickless system)" =09default y =20 +config OF_IDLE_STATES + bool "Idle states DT support" +=09depends on ARM || ARM64 +=09default n +=09help +=09 Allows the CPU idle framework to initialize CPU idle drivers +=09 state data by using DT provided nodes compliant with idle states +=09 device tree bindings. + menu "ARM CPU Idle Drivers" depends on ARM source "drivers/cpuidle/Kconfig.arm" diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile index d8bb1ff..d5ebf4b 100644 --- a/drivers/cpuidle/Makefile +++ b/drivers/cpuidle/Makefile @@ -4,6 +4,7 @@ =20 obj-y +=3D cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) +=3D coupled.o +obj-$(CONFIG_OF_IDLE_STATES)=09=09 +=3D of_idle_states.o =20 ##########################################################################= ######## # ARM SoC drivers diff --git a/drivers/cpuidle/of_idle_states.c b/drivers/cpuidle/of_idle_sta= tes.c new file mode 100644 index 0000000..acdbf45 --- /dev/null +++ b/drivers/cpuidle/of_idle_states.c @@ -0,0 +1,282 @@ +/* + * OF idle states parsing code. + * + * Copyright (C) 2014 ARM Ltd. + * Author: Lorenzo Pieralisi + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#define pr_fmt(fmt) "OF idle-states: " fmt + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "of_idle_states.h" + +struct state_elem { +=09struct list_head list; +=09struct device_node *node; +=09u32 val; +}; + +static struct list_head head __initdata =3D LIST_HEAD_INIT(head); + +static bool __init state_cpu_valid(struct device_node *state_node, +=09=09=09=09 struct device_node *cpu_node) +{ +=09int i =3D 0; +=09struct device_node *cpu_state; + +=09while ((cpu_state =3D of_parse_phandle(cpu_node, +=09=09=09=09=09 "cpu-idle-states", i++))) { +=09=09if (cpu_state && state_node =3D=3D cpu_state) { +=09=09=09of_node_put(cpu_state); +=09=09=09return true; +=09=09} +=09=09of_node_put(cpu_state); +=09} +=09return false; +} + +static bool __init state_cpus_valid(const cpumask_t *cpus, +=09=09=09=09 struct device_node *state_node) +{ +=09int cpu; +=09struct device_node *cpu_node; + +=09/* +=09 * Check if state is valid on driver cpumask cpus +=09 */ +=09for_each_cpu(cpu, cpus) { +=09=09cpu_node =3D of_get_cpu_node(cpu, NULL); + +=09=09if (!cpu_node) { +=09=09=09pr_err("Missing device node for CPU %d\n", cpu); +=09=09=09return false; +=09=09} + +=09=09if (!state_cpu_valid(state_node, cpu_node)) +=09=09=09return false; +=09} + +=09return true; +} + +static int __init state_cmp(void *priv, struct list_head *a, +=09=09=09 struct list_head *b) +{ +=09struct state_elem *ela, *elb; + +=09ela =3D container_of(a, struct state_elem, list); +=09elb =3D container_of(b, struct state_elem, list); + +=09return ela->val - elb->val; +} + +static int __init add_state_node(cpumask_t *cpumask, +=09=09=09=09 struct device_node *state_node) +{ +=09struct state_elem *el; +=09u32 val; + +=09pr_debug(" * %s...\n", state_node->full_name); + +=09if (!state_cpus_valid(cpumask, state_node)) +=09=09return -EINVAL; +=09/* +=09 * Parse just the property required to sort the states. +=09 * Since we are missing a value defining the energy +=09 * efficiency of a state, for now the sorting code uses +=09 * +=09 * exit-latency-us +=09 * +=09 * as sorting rank. +=09 */ +=09if (of_property_read_u32(state_node, "exit-latency-us", +=09=09=09=09 &val)) { +=09=09pr_debug(" * %s missing exit-latency-us property\n", +=09=09=09 state_node->full_name); +=09=09return -EINVAL; +=09} + +=09el =3D kmalloc(sizeof(*el), GFP_KERNEL); +=09if (!el) { +=09=09pr_err("%s failed to allocate memory\n", __func__); +=09=09return -ENOMEM; +=09} + +=09el->node =3D state_node; +=09el->val =3D val; +=09list_add_tail(&el->list, &head); + +=09return 0; +} + +static void __init init_state_node(struct cpuidle_driver *drv, +=09=09=09=09 struct device_node *state_node, +=09=09=09=09 int *cnt) +{ +=09struct cpuidle_state *idle_state; + +=09pr_debug(" * %s...\n", state_node->full_name); + +=09idle_state =3D &drv->states[*cnt]; + +=09if (of_property_read_u32(state_node, "exit-latency-us", +=09=09=09=09 &idle_state->exit_latency)) { +=09=09pr_debug(" * %s missing exit-latency-us property\n", +=09=09=09 state_node->full_name); +=09=09return; +=09} + +=09if (of_property_read_u32(state_node, "min-residency-us", +=09=09=09=09 &idle_state->target_residency)) { +=09=09pr_debug(" * %s missing min-residency-us property\n", +=09=09=09 state_node->full_name); +=09=09return; +=09} +=09/* +=09 * It is unknown to the idle driver if and when the tick_device +=09 * loses context when the CPU enters the idle states. To solve +=09 * this issue the tick device must be linked to a power domain +=09 * so that the idle driver can check on which states the device +=09 * loses its context. Current code takes the conservative choice +=09 * of defining the idle state as one where the tick device always +=09 * loses its context. On platforms where tick device never loses +=09 * its context (ie it is not a C3STOP device) this turns into +=09 * a nop. On platforms where the tick device does lose context in some +=09 * states, this code can be optimized, when power domain specifications +=09 * for ARM CPUs are finalized. +=09 */ +=09idle_state->flags =3D CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TIMER_STOP= ; + +=09strncpy(idle_state->name, state_node->name, CPUIDLE_NAME_LEN); +=09strncpy(idle_state->desc, state_node->name, CPUIDLE_NAME_LEN); + +=09(*cnt)++; +} + +static int __init init_idle_states(struct cpuidle_driver *drv, +=09=09=09=09 struct device_node *state_nodes[], +=09=09=09=09 unsigned int start_idx, bool init_nodes) +{ +=09struct state_elem *el; +=09struct list_head *curr, *tmp; +=09unsigned int cnt =3D start_idx; + +=09list_for_each_entry(el, &head, list) { +=09=09/* +=09=09 * Check if the init function has to fill the +=09=09 * state_nodes array on behalf of the CPUidle driver. +=09=09 */ +=09=09if (init_nodes) +=09=09=09state_nodes[cnt] =3D el->node; +=09=09/* +=09=09 * cnt is updated on return if a state was added. +=09=09 */ +=09=09init_state_node(drv, el->node, &cnt); + +=09=09if (cnt =3D=3D CPUIDLE_STATE_MAX) { +=09=09=09pr_warn("State index reached static CPU idle state limit\n"); +=09=09=09break; +=09=09} +=09} + +=09drv->state_count =3D cnt; + +=09list_for_each_safe(curr, tmp, &head) { +=09=09list_del(curr); +=09=09kfree(container_of(curr, struct state_elem, list)); +=09} + +=09/* +=09 * If no idle states are detected, return an error and let the idle +=09 * driver initialization fail accordingly. +=09 */ +=09return (cnt > start_idx) ? 0 : -ENODATA; +} + +static void __init add_idle_states(struct cpuidle_driver *drv, +=09=09=09=09 struct device_node *idle_states) +{ +=09struct device_node *state_node; + +=09for_each_child_of_node(idle_states, state_node) { +=09=09if ((!of_device_is_compatible(state_node, "arm,idle-state"))) { +=09=09=09pr_warn(" * %s: children of /cpus/idle-states must be \"arm,idle-= state\" compatible\n", +=09=09=09=09 state_node->full_name); +=09=09=09continue; +=09=09} +=09=09/* +=09=09 * If memory allocation fails, better bail out. +=09=09 * Initialized nodes are freed at initialization +=09=09 * completion in of_init_idle_driver(). +=09=09 */ +=09=09if ((add_state_node(drv->cpumask, state_node) =3D=3D -ENOMEM)) +=09=09=09break; +=09} +=09/* +=09 * Sort the states list before initializing the CPUidle driver +=09 * states array. +=09 */ +=09list_sort(NULL, &head, state_cmp); +} + +/** + * of_init_idle_driver() - Parse the DT idle states and initialize the + *=09=09=09 idle driver states array + * + * @drv:=09 Pointer to CPU idle driver to be initialized + * @state_nodes: Array of struct device_nodes to be initialized if + *=09=09 init_nodes =3D=3D true. Must be sized CPUIDLE_STATE_MAX + * @start_idx: First idle state index to be initialized + * @init_nodes: Boolean to request device nodes initialization + * + * On success the states array in the cpuidle driver contains + * initialized entries in the states array, starting from index start_idx. + * If init_nodes =3D=3D true, on success the state_nodes array is initiali= zed + * with idle state DT node pointers, starting from index start_idx, + * in a 1:1 relation with the idle driver states array. + * + * Return: + *=090 on success + *=09<0 on failure + */ +int __init of_init_idle_driver(struct cpuidle_driver *drv, +=09=09=09 struct device_node *state_nodes[], +=09=09=09 unsigned int start_idx, bool init_nodes) +{ +=09struct device_node *idle_states_node; +=09int ret; + +=09if (start_idx >=3D CPUIDLE_STATE_MAX) { +=09=09pr_warn("State index exceeds static CPU idle driver states array siz= e\n"); +=09=09return -EINVAL; +=09} + +=09if (WARN(init_nodes && !state_nodes, +=09=09"Requested nodes stashing in an invalid nodes container\n")) +=09=09return -EINVAL; + +=09idle_states_node =3D of_find_node_by_path("/cpus/idle-states"); +=09if (!idle_states_node) +=09=09return -ENOENT; + +=09add_idle_states(drv, idle_states_node); + +=09ret =3D init_idle_states(drv, state_nodes, start_idx, init_nodes); + +=09of_node_put(idle_states_node); + +=09return ret; +} diff --git a/drivers/cpuidle/of_idle_states.h b/drivers/cpuidle/of_idle_sta= tes.h new file mode 100644 index 0000000..049f94f --- /dev/null +++ b/drivers/cpuidle/of_idle_states.h @@ -0,0 +1,8 @@ +#ifndef __OF_IDLE_STATES +#define __OF_IDLE_STATES + +int __init of_init_idle_driver(struct cpuidle_driver *drv, +=09=09=09 struct device_node *state_nodes[], +=09=09=09 unsigned int start_idx, +=09=09=09 bool init_nodes); +#endif --=20 1.8.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) Date: Wed, 11 Jun 2014 17:18:37 +0100 Subject: [PATCH v4 3/6] drivers: cpuidle: implement OF based idle states infrastructure In-Reply-To: <1402503520-8611-1-git-send-email-lorenzo.pieralisi@arm.com> References: <1402503520-8611-1-git-send-email-lorenzo.pieralisi@arm.com> Message-ID: <1402503520-8611-4-git-send-email-lorenzo.pieralisi@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On most common ARM systems, the low-power states a CPU can be put into are not discoverable in HW and require device tree bindings to describe power down suspend operations and idle states parameters. In order to enable DT based idle states and configure idle drivers, this patch implements the bulk infrastructure required to parse the device tree idle states bindings and initialize the corresponding CPUidle driver states data. Code that initializes idle states checks the CPU idle driver cpumask so that multiple CPU idle drivers can be initialized through it in the kernel. The CPU idle driver cpumask defines which idle states should be considered valid for the driver, ie idle states that are valid on a set of cpus the idle driver manages. Signed-off-by: Lorenzo Pieralisi --- drivers/cpuidle/Kconfig | 9 ++ drivers/cpuidle/Makefile | 1 + drivers/cpuidle/of_idle_states.c | 282 +++++++++++++++++++++++++++++++++++++++ drivers/cpuidle/of_idle_states.h | 8 ++ 4 files changed, 300 insertions(+) create mode 100644 drivers/cpuidle/of_idle_states.c create mode 100644 drivers/cpuidle/of_idle_states.h diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig index 1b96fb9..760ce20 100644 --- a/drivers/cpuidle/Kconfig +++ b/drivers/cpuidle/Kconfig @@ -30,6 +30,15 @@ config CPU_IDLE_GOV_MENU bool "Menu governor (for tickless system)" default y +config OF_IDLE_STATES + bool "Idle states DT support" + depends on ARM || ARM64 + default n + help + Allows the CPU idle framework to initialize CPU idle drivers + state data by using DT provided nodes compliant with idle states + device tree bindings. + menu "ARM CPU Idle Drivers" depends on ARM source "drivers/cpuidle/Kconfig.arm" diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile index d8bb1ff..d5ebf4b 100644 --- a/drivers/cpuidle/Makefile +++ b/drivers/cpuidle/Makefile @@ -4,6 +4,7 @@ obj-y += cpuidle.o driver.o governor.o sysfs.o governors/ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o +obj-$(CONFIG_OF_IDLE_STATES) += of_idle_states.o ################################################################################## # ARM SoC drivers diff --git a/drivers/cpuidle/of_idle_states.c b/drivers/cpuidle/of_idle_states.c new file mode 100644 index 0000000..acdbf45 --- /dev/null +++ b/drivers/cpuidle/of_idle_states.c @@ -0,0 +1,282 @@ +/* + * OF idle states parsing code. + * + * Copyright (C) 2014 ARM Ltd. + * Author: Lorenzo Pieralisi + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#define pr_fmt(fmt) "OF idle-states: " fmt + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "of_idle_states.h" + +struct state_elem { + struct list_head list; + struct device_node *node; + u32 val; +}; + +static struct list_head head __initdata = LIST_HEAD_INIT(head); + +static bool __init state_cpu_valid(struct device_node *state_node, + struct device_node *cpu_node) +{ + int i = 0; + struct device_node *cpu_state; + + while ((cpu_state = of_parse_phandle(cpu_node, + "cpu-idle-states", i++))) { + if (cpu_state && state_node == cpu_state) { + of_node_put(cpu_state); + return true; + } + of_node_put(cpu_state); + } + return false; +} + +static bool __init state_cpus_valid(const cpumask_t *cpus, + struct device_node *state_node) +{ + int cpu; + struct device_node *cpu_node; + + /* + * Check if state is valid on driver cpumask cpus + */ + for_each_cpu(cpu, cpus) { + cpu_node = of_get_cpu_node(cpu, NULL); + + if (!cpu_node) { + pr_err("Missing device node for CPU %d\n", cpu); + return false; + } + + if (!state_cpu_valid(state_node, cpu_node)) + return false; + } + + return true; +} + +static int __init state_cmp(void *priv, struct list_head *a, + struct list_head *b) +{ + struct state_elem *ela, *elb; + + ela = container_of(a, struct state_elem, list); + elb = container_of(b, struct state_elem, list); + + return ela->val - elb->val; +} + +static int __init add_state_node(cpumask_t *cpumask, + struct device_node *state_node) +{ + struct state_elem *el; + u32 val; + + pr_debug(" * %s...\n", state_node->full_name); + + if (!state_cpus_valid(cpumask, state_node)) + return -EINVAL; + /* + * Parse just the property required to sort the states. + * Since we are missing a value defining the energy + * efficiency of a state, for now the sorting code uses + * + * exit-latency-us + * + * as sorting rank. + */ + if (of_property_read_u32(state_node, "exit-latency-us", + &val)) { + pr_debug(" * %s missing exit-latency-us property\n", + state_node->full_name); + return -EINVAL; + } + + el = kmalloc(sizeof(*el), GFP_KERNEL); + if (!el) { + pr_err("%s failed to allocate memory\n", __func__); + return -ENOMEM; + } + + el->node = state_node; + el->val = val; + list_add_tail(&el->list, &head); + + return 0; +} + +static void __init init_state_node(struct cpuidle_driver *drv, + struct device_node *state_node, + int *cnt) +{ + struct cpuidle_state *idle_state; + + pr_debug(" * %s...\n", state_node->full_name); + + idle_state = &drv->states[*cnt]; + + if (of_property_read_u32(state_node, "exit-latency-us", + &idle_state->exit_latency)) { + pr_debug(" * %s missing exit-latency-us property\n", + state_node->full_name); + return; + } + + if (of_property_read_u32(state_node, "min-residency-us", + &idle_state->target_residency)) { + pr_debug(" * %s missing min-residency-us property\n", + state_node->full_name); + return; + } + /* + * It is unknown to the idle driver if and when the tick_device + * loses context when the CPU enters the idle states. To solve + * this issue the tick device must be linked to a power domain + * so that the idle driver can check on which states the device + * loses its context. Current code takes the conservative choice + * of defining the idle state as one where the tick device always + * loses its context. On platforms where tick device never loses + * its context (ie it is not a C3STOP device) this turns into + * a nop. On platforms where the tick device does lose context in some + * states, this code can be optimized, when power domain specifications + * for ARM CPUs are finalized. + */ + idle_state->flags = CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TIMER_STOP; + + strncpy(idle_state->name, state_node->name, CPUIDLE_NAME_LEN); + strncpy(idle_state->desc, state_node->name, CPUIDLE_NAME_LEN); + + (*cnt)++; +} + +static int __init init_idle_states(struct cpuidle_driver *drv, + struct device_node *state_nodes[], + unsigned int start_idx, bool init_nodes) +{ + struct state_elem *el; + struct list_head *curr, *tmp; + unsigned int cnt = start_idx; + + list_for_each_entry(el, &head, list) { + /* + * Check if the init function has to fill the + * state_nodes array on behalf of the CPUidle driver. + */ + if (init_nodes) + state_nodes[cnt] = el->node; + /* + * cnt is updated on return if a state was added. + */ + init_state_node(drv, el->node, &cnt); + + if (cnt == CPUIDLE_STATE_MAX) { + pr_warn("State index reached static CPU idle state limit\n"); + break; + } + } + + drv->state_count = cnt; + + list_for_each_safe(curr, tmp, &head) { + list_del(curr); + kfree(container_of(curr, struct state_elem, list)); + } + + /* + * If no idle states are detected, return an error and let the idle + * driver initialization fail accordingly. + */ + return (cnt > start_idx) ? 0 : -ENODATA; +} + +static void __init add_idle_states(struct cpuidle_driver *drv, + struct device_node *idle_states) +{ + struct device_node *state_node; + + for_each_child_of_node(idle_states, state_node) { + if ((!of_device_is_compatible(state_node, "arm,idle-state"))) { + pr_warn(" * %s: children of /cpus/idle-states must be \"arm,idle-state\" compatible\n", + state_node->full_name); + continue; + } + /* + * If memory allocation fails, better bail out. + * Initialized nodes are freed at initialization + * completion in of_init_idle_driver(). + */ + if ((add_state_node(drv->cpumask, state_node) == -ENOMEM)) + break; + } + /* + * Sort the states list before initializing the CPUidle driver + * states array. + */ + list_sort(NULL, &head, state_cmp); +} + +/** + * of_init_idle_driver() - Parse the DT idle states and initialize the + * idle driver states array + * + * @drv: Pointer to CPU idle driver to be initialized + * @state_nodes: Array of struct device_nodes to be initialized if + * init_nodes == true. Must be sized CPUIDLE_STATE_MAX + * @start_idx: First idle state index to be initialized + * @init_nodes: Boolean to request device nodes initialization + * + * On success the states array in the cpuidle driver contains + * initialized entries in the states array, starting from index start_idx. + * If init_nodes == true, on success the state_nodes array is initialized + * with idle state DT node pointers, starting from index start_idx, + * in a 1:1 relation with the idle driver states array. + * + * Return: + * 0 on success + * <0 on failure + */ +int __init of_init_idle_driver(struct cpuidle_driver *drv, + struct device_node *state_nodes[], + unsigned int start_idx, bool init_nodes) +{ + struct device_node *idle_states_node; + int ret; + + if (start_idx >= CPUIDLE_STATE_MAX) { + pr_warn("State index exceeds static CPU idle driver states array size\n"); + return -EINVAL; + } + + if (WARN(init_nodes && !state_nodes, + "Requested nodes stashing in an invalid nodes container\n")) + return -EINVAL; + + idle_states_node = of_find_node_by_path("/cpus/idle-states"); + if (!idle_states_node) + return -ENOENT; + + add_idle_states(drv, idle_states_node); + + ret = init_idle_states(drv, state_nodes, start_idx, init_nodes); + + of_node_put(idle_states_node); + + return ret; +} diff --git a/drivers/cpuidle/of_idle_states.h b/drivers/cpuidle/of_idle_states.h new file mode 100644 index 0000000..049f94f --- /dev/null +++ b/drivers/cpuidle/of_idle_states.h @@ -0,0 +1,8 @@ +#ifndef __OF_IDLE_STATES +#define __OF_IDLE_STATES + +int __init of_init_idle_driver(struct cpuidle_driver *drv, + struct device_node *state_nodes[], + unsigned int start_idx, + bool init_nodes); +#endif -- 1.8.4