From: "" <caleb@calebthompson.io>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Jeremiah Mahler <jmmahler@gmail.com>,
Duy Nguyen <pclouds@gmail.com>,
Eric Sunshine <sunshine@sunshineco.com>,
Johannes Sixt <j.sixt@viscovery.net>, David Kastrup <dak@gnu.org>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v4 0/4] commit: support commit.verbose and --no-verbose
Date: Wed, 11 Jun 2014 13:24:35 -0500 [thread overview]
Message-ID: <1402511079-17735-1-git-send-email-caleb@calebthompson.io> (raw)
This patch allows people to set commit.verbose to implicitly send
--verbose to git-commit. It also introduces --no-verbose to override the
configuration setting.
This version incorporates changes suggested by Eric Sunshine, Duy
Nguyen, and Jeremiah Mahler.
It introduces several cleanup patches to t/t7505-commit-verbose.sh to
bring it closer to the current state of the tests as Eric has explained
them to me, then adds the verbose config and --no-verbose flag.
Since the last version of this patch
(http://marc.info/?l=git&m=140113063517118&w=2), I've made the following
changes:
* Remove the $PWD => $(pwd) change, as it was a misunderstanding of
t/README (Thank you to Johannes and David for pointing that out and
clarifying)
* Use consistent test naming (Thanks to Jeremiah)
* Switch from <<-EOF to <<-'EOF' without manual escaping in write_script
calls for the test editors check-for-diff and check-for-no-diff. The
proposed <<-\EOF syntax did not properly prevent the parameter
substitution on my machine, as both Eric and the documentation
suggested it should, but the quoted version seems to work fine.
(Thanks to Eric)
* Fix extra test_set_editor invocations and broken %%-chains created as a result
of the test_set_editor changes. (Thanks again to Eric)
------------------------------------------------------
Caleb Thompson (4):
commit test: Use test_config instead of git-config
commit test: Use write_script
commit test: test_set_editor in each test
commit: support commit.verbose and --no-verbose
Documentation/config.txt | 5 +++++
Documentation/git-commit.txt | 8 +++++++-
builtin/commit.c | 6 +++++-
contrib/completion/git-completion.bash | 1 +
t/t7507-commit-verbose.sh | 64 +++++++++++++++++++++++++++++++++++++++++++++++-----------------
5 files changed, 65 insertions(+), 19 deletions(-)
next reply other threads:[~2014-06-11 18:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:24 caleb [this message]
2014-06-11 18:24 ` [PATCH v4 1/4] commit test: Use test_config instead of git-config caleb
2014-06-12 8:41 ` Jeremiah Mahler
2014-06-12 13:51 ` Caleb Thompson
2014-06-12 18:04 ` Jeremiah Mahler
2014-06-12 18:08 ` Jeremiah Mahler
2014-06-12 18:23 ` Caleb Thompson
2014-06-12 18:46 ` Jeremiah Mahler
2014-06-12 19:23 ` Caleb Thompson
2014-06-11 18:24 ` [PATCH v4 2/4] commit test: Use write_script caleb
2014-06-11 18:24 ` [PATCH v4 3/4] commit test: test_set_editor in each test caleb
2014-06-11 18:24 ` [PATCH v4 4/4] commit: support commit.verbose and --no-verbose caleb
2014-06-11 20:41 ` René Scharfe
2014-06-11 21:26 ` Caleb Thompson
2014-06-12 14:36 ` Caleb Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402511079-17735-1-git-send-email-caleb@calebthompson.io \
--to=caleb@calebthompson.io \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jmmahler@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.