All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pranith Kumar <bobby.prani@gmail.com>
To: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	Josh Triplett <josh@joshtriplett.org>
Subject: [RFC PATCH 4/5] kernel/rcu/tree.c:3435 fix a sparse warning
Date: Wed, 11 Jun 2014 16:39:42 -0400	[thread overview]
Message-ID: <1402519183-12752-5-git-send-email-bobby.prani@gmail.com> (raw)
In-Reply-To: <1402519183-12752-1-git-send-email-bobby.prani@gmail.com>

kernel/rcu/tree.c:3435:21: warning: incorrect type in argument 1 (different modifiers)
kernel/rcu/tree.c:3435:21:    expected int ( *threadfn )( ... )
kernel/rcu/tree.c:3435:21:    got int ( static [toplevel] [noreturn] *<noident> )( ... )

by removing __noreturn attribute and adding unreachable() as suggested on the
mailing list: http://www.kernelhub.org/?p=2&msg=436683

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
 kernel/rcu/tree.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 9ab84d3..6029a2e 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1689,7 +1689,7 @@ static void rcu_gp_cleanup(struct rcu_state *rsp)
 /*
  * Body of kthread that handles grace periods.
  */
-static int __noreturn rcu_gp_kthread(void *arg)
+static int rcu_gp_kthread(void *arg)
 {
 	int fqs_state;
 	int gf;
@@ -1777,6 +1777,9 @@ static int __noreturn rcu_gp_kthread(void *arg)
 		/* Handle grace-period end. */
 		rcu_gp_cleanup(rsp);
 	}
+
+	unreachable();
+	return 0;
 }
 
 /*
-- 
1.9.1


  parent reply	other threads:[~2014-06-11 20:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 20:39 [RFC PATCH 0/5] rcu: fix sparse warnings Pranith Kumar
2014-06-11 20:39 ` [RFC PATCH 1/5] kernel/rcu/tree.c:1272 fix a sparse warning Pranith Kumar
2014-06-12 23:16   ` Paul E. McKenney
2014-06-13  4:54     ` Pranith Kumar
2014-06-13  5:52       ` Pranith Kumar
2014-06-11 20:39 ` [RFC PATCH 2/5] kernel/rcu/tree_plugin.h:1494 " Pranith Kumar
2014-06-26 19:39   ` Paul E. McKenney
2014-06-11 20:39 ` [RFC PATCH 3/5] kernel/rcu/tree_plugin.h:990 " Pranith Kumar
2014-06-26 19:39   ` Paul E. McKenney
2014-06-11 20:39 ` Pranith Kumar [this message]
2014-06-11 21:25   ` [RFC PATCH 4/5] kernel/rcu/tree.c:3435 " josh
2014-06-12  1:37     ` Pranith Kumar
2014-06-11 20:39 ` [RFC PATCH 5/5] kernel/rcu/rcutorture.c:185 " Pranith Kumar
2014-06-11 21:47   ` josh
2014-07-08 22:35     ` Paul E. McKenney
2014-07-08 22:46       ` Pranith Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402519183-12752-5-git-send-email-bobby.prani@gmail.com \
    --to=bobby.prani@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.