All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Campbell <ian.campbell@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Jackson <ijackson@chiark.greenend.org.uk>
Subject: [PATCH 2/6] ts-xen-build-prep: Abolish "background" parameter to lvextend
Date: Wed, 11 Jun 2014 21:47:41 +0100	[thread overview]
Message-ID: <1402519665-17578-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1402519665-17578-1-git-send-email-ian.jackson@eu.citrix.com>

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---
 ts-xen-build-prep |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index 0e68cd3..6443351 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -65,11 +65,11 @@ sub lvextend_stage1 () {
         fi
 END
 
-    lvextend1('disk extend initial',       30, 0);
+    lvextend1('disk extend initial',       300);
 }
 
 sub lvextend_stage2 () {
-    lvextend1('disk extend background', undef, 1);
+    lvextend1('disk extend subsequent',  undef);
 }
 
 sub vginfo () {
@@ -80,7 +80,7 @@ sub vginfo () {
 }
 
 sub lvextend1 ($$$) {
-    my ($what, $max_more_gb, $background)  = @_;
+    my ($what, $max_more_gb)  = @_;
 
     my $lv= "/dev/$vg/root";
 
@@ -156,11 +156,7 @@ sub lvextend1 ($$$) {
     my $timeout = 2000 + int($pe_size * 0.000003 * $more_pe);
     logm("$what: ${pe_size}k x $more_pe (timeout=$timeout)");
     my $cmd = "resize2fs $lv";
-    if (!$background) {
-	target_cmd_root($ho, $cmd, $timeout);
-    } else {
-	target_cmd_root($ho, "$cmd >>resizefs.log 2>&1 </dev/null &", 30);
-    }
+    target_cmd_root($ho, $cmd, $timeout);
 }
 
 sub prep () {
-- 
1.7.10.4

  reply	other threads:[~2014-06-11 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 20:47 [PATCH 1/6] Revert "ts-xen-build-prep: Run the backgrounded resize2fs with ionice" Ian Jackson
2014-06-11 20:47 ` Ian Jackson [this message]
2014-06-12  8:26   ` [PATCH 2/6] ts-xen-build-prep: Abolish "background" parameter to lvextend Ian Campbell
2014-06-11 20:47 ` [PATCH 3/6] TestSupport: break out lv_dev_mapper Ian Jackson
2014-06-12  8:27   ` Ian Campbell
2014-06-11 20:47 ` [PATCH 4/6] ts-xen-build-prep: Break out determine_vg_lv Ian Jackson
2014-06-11 20:47 ` [PATCH 5/6] ts-xen-build-prep: mkfs a new /home/osstest, don't resize2fs Ian Jackson
2014-06-12  8:32   ` Ian Campbell
2014-06-11 20:47 ` [PATCH 6/6] Revert "ts-logs-capture: collect resize2fs.log" Ian Jackson
2014-06-12  8:33 ` [PATCH 1/6] Revert "ts-xen-build-prep: Run the backgrounded resize2fs with ionice" Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402519665-17578-2-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@eu.citrix.com \
    --cc=ijackson@chiark.greenend.org.uk \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.