From: Fugang Duan <b38611@freescale.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <b38611@freescale.com>,
<ezequiel.garcia@free-electrons.com>, <b20596@freescale.com>,
<David.Laight@ACULAB.COM>, <eric.dumazet@gmail.com>
Subject: [PATCH v5 2/6] net: fec: Enable IP header hardware checksum
Date: Thu, 12 Jun 2014 08:16:19 +0800 [thread overview]
Message-ID: <1402532183-14910-3-git-send-email-b38611@freescale.com> (raw)
In-Reply-To: <1402532183-14910-1-git-send-email-b38611@freescale.com>
IP header checksum is calcalated by network layer in default.
To support software TSO, it is better to use HW calculate the
IP header checksum.
FEC hw checksum feature request the checksum field in frame
is zero, otherwise the calculative CRC is not correct.
For segmentated TCP packet, HW calculate the IP header checksum again,
it doesn't bring any impact. For SW TSO, HW calculated checksum bring
better performance.
Signed-off-by: Fugang Duan <B38611@freescale.com>
---
drivers/net/ethernet/freescale/fec_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index ee8e547..55b55d2 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -314,6 +314,7 @@ fec_enet_clear_csum(struct sk_buff *skb, struct net_device *ndev)
if (unlikely(skb_cow_head(skb, 0)))
return -1;
+ ip_hdr(skb)->check = 0;
*(__sum16 *)(skb->head + skb->csum_start + skb->csum_offset) = 0;
return 0;
@@ -395,7 +396,7 @@ static int txq_submit_skb(struct sk_buff *skb, struct net_device *ndev)
* are done by the kernel
*/
if (skb->ip_summed == CHECKSUM_PARTIAL)
- ebdp->cbd_esc |= BD_ENET_TX_PINS;
+ ebdp->cbd_esc |= BD_ENET_TX_PINS | BD_ENET_TX_IINS;
}
}
--
1.7.8
next prev parent reply other threads:[~2014-06-12 1:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 0:16 [PATCH v5 0/6] net: fec: Enable Software TSO to improve the tx performance Fugang Duan
2014-06-12 0:16 ` [PATCH v5 1/6] net: fec: Factorize the .xmit transmit function Fugang Duan
2014-06-12 0:16 ` Fugang Duan [this message]
2014-06-12 0:16 ` [PATCH v5 3/6] net: fec: Factorize feature setting Fugang Duan
2014-06-12 0:16 ` [PATCH v5 4/6] net: fec: Increase buffer descriptor entry number Fugang Duan
2014-06-12 0:16 ` [PATCH v5 5/6] net: fec: Add Scatter/gather support Fugang Duan
2014-06-12 0:16 ` [PATCH v5 6/6] net: fec: Add software TSO support Fugang Duan
2014-06-12 18:02 ` [PATCH v5 0/6] net: fec: Enable Software TSO to improve the tx performance David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402532183-14910-3-git-send-email-b38611@freescale.com \
--to=b38611@freescale.com \
--cc=David.Laight@ACULAB.COM \
--cc=b20596@freescale.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.