[Qemu-devel] [PATCH] virtio-serial: remove useless set_config function

[Qemu-devel] [PATCH] virtio-serial: remove useless set_config function

[Paolo Bonzini]

Its only contents are a dead memcpy.  Since it is optional,
drop the function altogether.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/char/virtio-serial-bus.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
index 2b647b6..a2958ff 100644
--- a/hw/char/virtio-serial-bus.c
+++ b/hw/char/virtio-serial-bus.c
@@ -465,13 +465,6 @@ static void get_config(VirtIODevice *vdev, uint8_t *config_data)
     memcpy(config_data, &vser->config, sizeof(struct virtio_console_config));
 }
 
-static void set_config(VirtIODevice *vdev, const uint8_t *config_data)
-{
-    struct virtio_console_config config;
-
-    memcpy(&config, config_data, sizeof(config));
-}
-
 static void guest_reset(VirtIOSerial *vser)
 {
     VirtIOSerialPort *port;
@@ -1024,7 +1017,6 @@ static void virtio_serial_class_init(ObjectClass *klass, void *data)
     vdc->unrealize = virtio_serial_device_unrealize;
     vdc->get_features = get_features;
     vdc->get_config = get_config;
-    vdc->set_config = set_config;
     vdc->set_status = set_status;
     vdc->reset = vser_reset;
 }
-- 
1.9.3

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-serial: remove useless set_config function

[Michael Tokarev]

12.06.2014 13:20, Paolo Bonzini wrote:
> Its only contents are a dead memcpy.  Since it is optional,
> drop the function altogether.

Applied to -trivial, thanks!

/mjt