All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH 2/9] drm/i915: Don't let update_psr function actually enable PSR.
Date: Thu, 12 Jun 2014 10:16:39 -0700	[thread overview]
Message-ID: <1402593406-17869-2-git-send-email-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <1402593406-17869-1-git-send-email-rodrigo.vivi@intel.com>

Being more conservative by enabling PSR only on psr_enable function.

Reviewed-by: Vijay Purushothaman <vijay.a.purushothaman@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index da65adc..a7b4ac9 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1805,9 +1805,6 @@ static void intel_edp_psr_do_enable(struct intel_dp *intel_dp)
 	    intel_edp_is_psr_enabled(dev))
 		return;
 
-	/* Setup PSR once */
-	intel_edp_psr_setup(intel_dp);
-
 	/* Enable PSR on the panel */
 	intel_edp_psr_enable_sink(intel_dp);
 
@@ -1824,6 +1821,9 @@ void intel_edp_psr_enable(struct intel_dp *intel_dp)
 		return;
 	}
 
+	/* Setup PSR once */
+	intel_edp_psr_setup(intel_dp);
+
 	if (intel_edp_psr_match_conditions(intel_dp) &&
 	    !intel_edp_is_psr_enabled(dev))
 		intel_edp_psr_do_enable(intel_dp);
@@ -1848,12 +1848,16 @@ void intel_edp_psr_disable(struct intel_dp *intel_dp)
 
 void intel_edp_psr_update(struct drm_device *dev)
 {
+	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_encoder *encoder;
 	struct intel_dp *intel_dp = NULL;
 
 	if (!HAS_PSR(dev))
 		return;
 
+	if (!dev_priv->psr.setup_done)
+		return;
+
 	list_for_each_entry(encoder, &dev->mode_config.encoder_list, base.head)
 		if (encoder->type == INTEL_OUTPUT_EDP) {
 			intel_dp = enc_to_intel_dp(&encoder->base);
-- 
1.9.3

  reply	other threads:[~2014-06-13  0:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 17:16 [PATCH 1/9] drm/i915: Use HAS_PSR to avoid unecessary interactions Rodrigo Vivi
2014-06-12 17:16 ` Rodrigo Vivi [this message]
2014-06-12 17:16 ` [PATCH 3/9] drm/i915: Do not try to enable PSR when Panel doesn't suport it Rodrigo Vivi
2014-06-12 17:16 ` [PATCH 4/9] drm/i915: Force PSR exit by inactivating it Rodrigo Vivi
2014-06-13  6:53   ` Daniel Vetter
2014-06-13 12:10     ` [PATCH] " Rodrigo Vivi
2014-06-13 19:24       ` Daniel Vetter
2014-06-13 19:45       ` Chris Wilson
2014-06-12 17:16 ` [PATCH 5/9] drm/i915: BDW PSR: Add single frame update support Rodrigo Vivi
2014-06-12 17:16 ` [PATCH 6/9] drm/i915: BDW PSR: Remove limitations that aren't valid for BDW Rodrigo Vivi
2014-06-13  8:11   ` Daniel Vetter
2014-06-12 17:16 ` [PATCH 7/9] drm/i915: BDW PSR: Remove DDIA limitation for Broadwell Rodrigo Vivi
2014-06-12 17:16 ` [PATCH 8/9] drm/i915: Improve PSR debugfs status Rodrigo Vivi
2014-06-12 17:16 ` [PATCH 9/9] drm/i915: PSR HSW: update after enabling sprite Rodrigo Vivi
2014-06-13  8:01   ` Daniel Vetter
2014-06-13 12:02     ` Jani Nikula
2014-06-13 13:49       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402593406-17869-2-git-send-email-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.