* [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove()
@ 2014-06-13 17:19 Christian Engelmayer
2014-06-16 9:06 ` Charles Keepax
2014-06-17 14:40 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Christian Engelmayer @ 2014-06-13 17:19 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Fabio Estevam, Lars-Peter Clausen, Charles Keepax,
Xiubo Li, patches, alsa-devel, linux-kernel,
Christian Engelmayer
Commit a0b148b4 (ASoC: wm8985: Use devm_regulator_bulk_get()) removed the last
user of pointer wm8985 to struct wm8985_priv. Thus remove it. Detected by
Coverity CID 1222150.
Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
---
Compile tested. Applies against branch for-next in tree
git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
---
sound/soc/codecs/wm8985.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/wm8985.c b/sound/soc/codecs/wm8985.c
index 0f5780c..cbbdfbb 100644
--- a/sound/soc/codecs/wm8985.c
+++ b/sound/soc/codecs/wm8985.c
@@ -980,9 +980,6 @@ static int wm8985_resume(struct snd_soc_codec *codec)
static int wm8985_remove(struct snd_soc_codec *codec)
{
- struct wm8985_priv *wm8985;
-
- wm8985 = snd_soc_codec_get_drvdata(codec);
wm8985_set_bias_level(codec, SND_SOC_BIAS_OFF);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove()
2014-06-13 17:19 [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove() Christian Engelmayer
@ 2014-06-16 9:06 ` Charles Keepax
2014-06-17 14:40 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2014-06-16 9:06 UTC (permalink / raw)
To: Christian Engelmayer
Cc: Mark Brown, Liam Girdwood, Fabio Estevam, Lars-Peter Clausen,
Xiubo Li, patches, alsa-devel, linux-kernel
On Fri, Jun 13, 2014 at 07:19:28PM +0200, Christian Engelmayer wrote:
> Commit a0b148b4 (ASoC: wm8985: Use devm_regulator_bulk_get()) removed the last
> user of pointer wm8985 to struct wm8985_priv. Thus remove it. Detected by
> Coverity CID 1222150.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove()
2014-06-13 17:19 [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove() Christian Engelmayer
2014-06-16 9:06 ` Charles Keepax
@ 2014-06-17 14:40 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-06-17 14:40 UTC (permalink / raw)
To: Christian Engelmayer
Cc: Liam Girdwood, Fabio Estevam, Lars-Peter Clausen, Charles Keepax,
Xiubo Li, patches, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
On Fri, Jun 13, 2014 at 07:19:28PM +0200, Christian Engelmayer wrote:
> Commit a0b148b4 (ASoC: wm8985: Use devm_regulator_bulk_get()) removed the last
> user of pointer wm8985 to struct wm8985_priv. Thus remove it. Detected by
> Coverity CID 1222150.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-17 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-13 17:19 [PATCH] ASoC: wm8985: Remove unused pointer in wm8985_remove() Christian Engelmayer
2014-06-16 9:06 ` Charles Keepax
2014-06-17 14:40 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.