From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 06/21] xen/arm: segregate and split GIC low level functionality Date: Tue, 17 Jun 2014 13:15:33 +0100 Message-ID: <1403007333.16844.74.camel@kazak.uk.xensource.com> References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com> <1402580192-13937-7-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1402580192-13937-7-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > GIC driver contains both generic and hardware specific low > level functionality in gic.c file. > > With this patch, low level functionality is moved to separate > file gic-v2.c and generic code is kept in gic.c file > > Callbacks are registered by low level driver with generic driver > and are called whereever required. > > The locking mechanism is not changed. > > This helps to separate generic and hardware functionality > and implement future hardware version drivers. > > Signed-off-by: Vijaya Kumar K I've no comments over and above what Stefano and Julien have already said. Ian.