From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v5 16/21] xen/arm: split vgic driver into
 generic and vgic-v2 driver
Date: Tue, 17 Jun 2014 14:21:24 +0100
Message-ID: <1403011284.16844.101.camel@kazak.uk.xensource.com>
References: <1402580192-13937-1-git-send-email-vijay.kilari@gmail.com>
	<1402580192-13937-17-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1402580192-13937-17-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com
Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@gmail.com wrote:
> +extern int vgic_to_sgi(struct vcpu *v, register_t sgir,
> +                       enum gic_sgi_mode irqmode, int virq,
> +                       unsigned long vcpu_mask);

No externs in C files please. Put them in the appropriate header.

Ian.