All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@citrix.com, xen-devel@lists.xensource.com
Subject: Re: [PATCH v9 12/12] xen/arm: gic_events_need_delivery and irq priorities
Date: Wed, 18 Jun 2014 11:37:42 +0100	[thread overview]
Message-ID: <1403087862.24051.0.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1402409240-28114-12-git-send-email-stefano.stabellini@eu.citrix.com>


On Tue, 2014-06-10 at 15:07 +0100, Stefano Stabellini wrote:
> Introduce GIC_IRQ_GUEST_ACTIVE to track which irqs are currently
> active in the guest.
> 
> gic_events_need_delivery should only return positive if an outstanding
> pending irq has an higher group priority than the currently active group
> priotity and the priority mask.
> Read GICH_APR to find the active group priority.
> Read GICH_VMCR to find the priority mask.
> Find the highest priority non-active enabled irq by going through the
> inflight list.
> 
> In gic_restore_pending_irqs replace lower priority pending (and not
> active) irqs in GICH_LRs with higher priority irqs if no more GICH_LRs
> are available.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> ---
> 
> Changes in v9:
> - gic_events_need_delivery: read GICH_APR to find the active group
> priority;
> - gic_events_need_delivery: simplify the search loop.

Thanks, I can actually grok this version ;-)

Acked this + #9.

AIUI there is no relationship here with "xen/arm: make accesses to
desc->status flags atomic" which fixes an issue which already present
before this series.

There applied (this series, not the atomic flags one, yet). thanks.

Ian.

      parent reply	other threads:[~2014-06-18 10:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 14:06 [PATCH v9 0/12] remove maintenance interrupts Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 01/12] xen/arm: no need to set HCR_VI when using the vgic to inject irqs Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 02/12] xen/arm: remove unused virtual parameter from vgic_vcpu_inject_irq Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 03/12] xen/arm: set GICH_HCR_UIE if all the LRs are in use Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 04/12] xen/arm: support HW interrupts, do not request maintenance_interrupts Stefano Stabellini
2014-06-11 13:40   ` Julien Grall
2014-06-12 15:57     ` Stefano Stabellini
2014-06-12 21:59       ` Julien Grall
2014-06-13 10:20         ` Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 05/12] xen/arm: nr_lrs should be uint8_t Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 06/12] xen/arm: keep track of the GICH_LR used for the irq in struct pending_irq Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 07/12] xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 08/12] xen/arm: rename GIC_IRQ_GUEST_PENDING to GIC_IRQ_GUEST_QUEUED Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 09/12] xen/arm: second irq injection while the first irq is still inflight Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 10/12] xen/arm: don't protect GICH and lr_queue accesses with gic.lock Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 11/12] xen/arm: introduce GIC_PRI_TO_GUEST macro Stefano Stabellini
2014-06-10 14:07 ` [PATCH v9 12/12] xen/arm: gic_events_need_delivery and irq priorities Stefano Stabellini
2014-06-18 10:36   ` Ian Campbell
2014-06-18 11:47     ` Julien Grall
2014-06-18 12:51       ` Stefano Stabellini
2014-06-18 12:59         ` Julien Grall
2014-06-18 13:17         ` Ian Campbell
2014-06-18 10:37   ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403087862.24051.0.camel@kazak.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.