From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 1/8] libxc: allow xc_get/set_hvm_param() to
 get/set 64-bit values
Date: Wed, 18 Jun 2014 14:05:29 +0100
Message-ID: <1403096729.32540.20.camel@kazak.uk.xensource.com>
References: <1402585478-3389-1-git-send-email-david.vrabel@citrix.com>
	<1402585478-3389-2-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1WxFYz-00089N-1l
	for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 13:06:05 +0000
In-Reply-To: <1402585478-3389-2-git-send-email-david.vrabel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-06-12 at 16:04 +0100, David Vrabel wrote:
> HVMOP_get_param and HVMOP_set_param take a uint32_t for the parameter
> index and a uint64_t for the value.  So, make the corresponding libxc
> function take the same types.

Sadly:

<builddir>tools/qemu-xen-dir/xen-all.c: In function 'xen_hvm_init':
<builddir>tools/qemu-xen-dir/xen-all.c:1101:5: error: passing argument 4 of 'xc_get_hvm_param' from incompatible pointer type [-Werror]
In file included from <builddir>tools/qemu-xen-dir/include/hw/xen/xen_common.h:9:0,
                 from <builddir>tools/qemu-xen-dir/xen-all.c:15:
<builddir>tools/../tools/libxc/xenctrl.h:1812:5: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'
<builddir>tools/qemu-xen-dir/xen-all.c:1110:5: error: passing argument 4 of 'xc_get_hvm_param' from incompatible pointer type [-Werror]
In file included from <builddir>tools/qemu-xen-dir/include/hw/xen/xen_common.h:9:0,
                 from <builddir>tools/qemu-xen-dir/xen-all.c:15:
<builddir>tools/../tools/libxc/xenctrl.h:1812:5: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'
<builddir>tools/qemu-xen-dir/xen-all.c:1132:13: error: passing argument 4 of 'xc_get_hvm_param' from incompatible pointer type [-Werror]
In file included from <builddir>tools/qemu-xen-dir/include/hw/xen/xen_common.h:9:0,
                 from <builddir>tools/qemu-xen-dir/xen-all.c:15:
<builddir>tools/../tools/libxc/xenctrl.h:1812:5: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'
cc1: all warnings being treated as errors

So I don't think it is going to be possible to just make this change so
easily. You'd need to to at least upstream a qemu patch which involved a
configure check I think :-(

You might find it easier to introduce a new name for these functions,
although sadly the only really sensible one is already taken...

:-/

Ian.