From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 3/6] libxl: implement channels via PV console rings Date: Wed, 18 Jun 2014 14:31:34 +0100 Message-ID: <1403098294.6568.9.camel@kazak.uk.xensource.com> References: <1402912195-24732-1-git-send-email-dave.scott@citrix.com> <1402912195-24732-4-git-send-email-dave.scott@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxFxo-0001cs-6i for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 13:31:44 +0000 In-Reply-To: <1402912195-24732-4-git-send-email-dave.scott@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Scott Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2014-06-16 at 10:49 +0100, David Scott wrote: > We extend the (internal) console type with a 'name' (string) > which isn't used by the default built-in console 0. Normally this would be part of the same patch which added the idl change. You also need to add a #define LIBXL_HAVE_FOO to libxl.h to flag the presence of this feature. Lastly - I don't see any libxl_device_channel_* ops added here, is it intentional that it not be possible to dynamically add these things? > + switch (channel->type) { > + case LIBXL_CHANNEL_TYPE_NONE: > + case LIBXL_CHANNEL_TYPE_PTY: > + /* No path is needed */ How do I go about finding the PTY for a channel? Ian.