From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salter Subject: Re: [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*() Date: Wed, 18 Jun 2014 09:59:06 -0400 Message-ID: <1403099946.32688.33.camel__439.518984831189$1403100783$gmane$org@deneb.redhat.com> References: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com> <1402678823-24589-2-git-send-email-daniel.kiper@oracle.com> <20140618121709.GF24049@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WxGVP-0005pg-JB for xen-devel@lists.xenproject.org; Wed, 18 Jun 2014 14:06:27 +0000 In-Reply-To: <20140618121709.GF24049@console-pimps.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matt Fleming Cc: mjg59@srcf.ucam.org, jeremy@goop.org, linux-efi@vger.kernel.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com, Daniel Kiper , x86@kernel.org, linux-kernel@vger.kernel.org, matt.fleming@intel.com, tglx@linutronix.de, david.vrabel@citrix.com, jbeulich@suse.com, hpa@zytor.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, mingo@redhat.com, stefano.stabellini@eu.citrix.com, eshelton@pobox.com List-Id: xen-devel@lists.xenproject.org On Wed, 2014-06-18 at 13:17 +0100, Matt Fleming wrote: > Now, the only difference between early_memremap() and early_ioremap(), > at least on x86, is PAGE_KERNEL vs. PAGE_KERNEL_IO, where PAGE_KERNEL_IO > has the additional _PAGE_BIT_IOMAP bit set in the pte. But that's a > software bit for x86. I can't comment on the x86 MMU details, but using early_memremap() will get rid of some sparse warnings in the current code.