All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 3/4] expr: meta: Delete the last comma character in json text.
Date: Sat, 21 Jun 2014 18:29:59 +0200	[thread overview]
Message-ID: <1403368200-8860-4-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1403368200-8860-1-git-send-email-anarey@gmail.com>

Code refactoring to delete correctly the last comma character in json text.

Signed-off-by: Ana Rey <anarey@gmail.com>
---
 src/expr/meta.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/expr/meta.c b/src/expr/meta.c
index 25026a9..95d538c 100644
--- a/src/expr/meta.c
+++ b/src/expr/meta.c
@@ -322,9 +322,10 @@ nft_rule_expr_meta_snprintf_json(char *buf, size_t size,
 	}
 
 	/* Remove the last separator characther */
-	buf[offset-1] = '\0';
+	if (offset > 0)
+		offset--;
 
-	return offset-1;
+	return offset;
 }
 
 static int
-- 
2.0.0


  parent reply	other threads:[~2014-06-21 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-21 16:29 [libnftnl PATCH 0/4] expr: meta: Do not print unset values in xml and json Ana Rey
2014-06-21 16:29 ` [libnftnl PATCH 1/4] expr: meta: Use nft_rule_expr_set_* in the xml parsing code Ana Rey
2014-06-21 16:29 ` [libnftnl PATCH 2/4] expr: meta: Do not print unset values in xml file Ana Rey
2014-06-21 16:29 ` Ana Rey [this message]
2014-06-21 16:30 ` [libnftnl PATCH 4/4] expr: meta: Do not print unset values in json file Ana Rey
2014-06-23  9:11 ` [libnftnl PATCH 0/4] expr: meta: Do not print unset values in xml and json Arturo Borrero Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403368200-8860-4-git-send-email-anarey@gmail.com \
    --to=anarey@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.