From: Chase Southwood <chase.southwood@gmail.com>
To: gregkh@linuxfoundation.org
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Chase Southwood <chase.southwood@gmail.com>
Subject: [PATCH v3 1/5] staging: comedi: addi_apci_1564: remove use of devpriv->b_OutputMemoryStatus
Date: Sat, 21 Jun 2014 17:24:39 -0500 [thread overview]
Message-ID: <1403389479-19986-1-git-send-email-chase.southwood@gmail.com> (raw)
In-Reply-To: <1403389429-19793-1-git-send-email-chase.southwood@gmail.com>
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: H Hartley Sweeeten <hsweeten@visionengravers.com>
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
index 0ba5385..19de400 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
@@ -149,11 +149,6 @@ static int apci1564_do_config(struct comedi_device *dev,
return -EINVAL;
}
- if (data[0])
- devpriv->b_OutputMemoryStatus = 1;
- else
- devpriv->b_OutputMemoryStatus = 0;
-
if (data[1] == 1)
ul_Command = ul_Command | 0x1;
else
--
1.9.3
next prev parent reply other threads:[~2014-06-21 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 22:23 [PATCH v3 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality Chase Southwood
2014-06-21 22:24 ` Chase Southwood [this message]
2014-06-21 22:25 ` [PATCH v3 2/5] staging: comedi: addi_apci_1564: remove unused static variables Chase Southwood
2014-06-21 22:25 ` [PATCH v3 3/5] staging: comedi: addi_apci_1564: introduce apci1564_private struct Chase Southwood
2014-06-21 22:25 ` [PATCH v3 4/5] staging: comedi: addi_apci_1564: add Change-of-State interrupt subdevice and required functions Chase Southwood
2014-06-21 22:26 ` [PATCH v3 5/5] staging: comedi: addi_apci_1564: move apci1564_interrupt() into addi_apci_1564.c Chase Southwood
2014-06-23 10:23 ` [PATCH v3 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403389479-19986-1-git-send-email-chase.southwood@gmail.com \
--to=chase.southwood@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.