From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: make system freeze support depend on CONFIG_ACPI_SLEEP Date: Tue, 24 Jun 2014 17:37:12 +0300 Message-ID: <1403620632.24758.26.camel@intelbox> References: <1403527562-28919-1-git-send-email-imre.deak@intel.com> <87a9928lbu.fsf@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1969029823==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 2300E89D57 for ; Tue, 24 Jun 2014 07:37:40 -0700 (PDT) In-Reply-To: <87a9928lbu.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , "Rafael J. Wysocki" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1969029823== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Joba3M8vsGAiI1cjZkt+" --=-Joba3M8vsGAiI1cjZkt+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2014-06-24 at 16:54 +0300, Jani Nikula wrote: > On Mon, 23 Jun 2014, Imre Deak wrote: > > To achieve further power savings during system freeze (aka connected > > standby, or s0ix) we have to send a PCI_D1 opregion notification. As > > the information about the state we're entering (system freeze, > > suspend to ram or suspend to disk) is only available through the ACPI > > subsystem, make this support depend on the relevant kconfig option. > > Things will still work if this option isn't set, albeit with less than > > optimial power saving. > > > > This also fixes a compile breakage when the option is not set introduce= d > > in > > > > commit e5747e3adcd67ae27105003ec99fb58cba180105 > > Author: Jesse Barnes > > Date: Thu Jun 12 08:35:47 2014 -0700 > > > > drm/i915: send proper opregion notifications on suspend/resume > > > > Reported-by: Randy Dunlap > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/i915_drv.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i91= 5_drv.c > > index 7ae4e2a..43dc8f7 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -544,10 +544,11 @@ static int i915_drm_freeze(struct drm_device *dev= ) > > =20 > > i915_save_state(dev); > > =20 > > - if (acpi_target_system_state() >=3D ACPI_STATE_S3) > > - opregion_target_state =3D PCI_D3cold; > > - else > > + opregion_target_state =3D PCI_D3cold; > > +#if IS_ENABLED(CONFIG_ACPI_SLEEP) >=20 > Maybe this should just check for CONFIG_ACPI? I wanted to send the PCI_D1 signal only if we are sure that the target sleep state is S0ix (or S1/2) and fall back to the old behavior to send PCI_D3cold in all other cases. But you are right, it would make much sense if CONFIG_ACPI_SLEEP=3Dn the target state would be always S0ix. Rafael could you confirm this? --Imre >=20 > BR, > Jani. >=20 > > + if (acpi_target_system_state() < ACPI_STATE_S3) > > opregion_target_state =3D PCI_D1; > > +#endif > > intel_opregion_notify_adapter(dev, opregion_target_state); > > =20 > > intel_uncore_forcewake_reset(dev, false); > > --=20 > > 1.8.4 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >=20 --=-Joba3M8vsGAiI1cjZkt+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAABAgAGBQJTqY0YAAoJEORIIAnNuWDFox0IAII5vV4ERwrtTBz4kaTRkfEz JztCyRYNsJnAfCSbfhbndsLhrFFvjIg0iOPSMkSD76FsxSYjNPZC7VVMVLDgibLf /1f+09lUE87BuJ81HhnnYrLZLg2dXzoJ6WUnViFz1VcE6XC2sz7LvwlpxjWad5zU 4nwu/TKHX1yea3zHE2f79CxWx50tGS4/g3a5vZYbZi0OTbOYy4TaRZAipuayraTp x/iEOCovxNcvmHFumg68vkNsosZoFEs4RQdShmlYA871prA17L9sCN/V5aUezzA6 p3fgYNv7ATe+NvSs/vNkGLTjrqEhj6kqERRLVyrWz86JoEmNIGwMrm82hVqzP4E= =6ZJn -----END PGP SIGNATURE----- --=-Joba3M8vsGAiI1cjZkt+-- --===============1969029823== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1969029823==--