From mboxrd@z Thu Jan 1 00:00:00 1970 From: Declan Doherty Subject: [PATCH v6 2/6] Support for unique interface naming of pmds Date: Tue, 24 Jun 2014 15:52:07 +0100 Message-ID: <1403621531-30487-3-git-send-email-declan.doherty@intel.com> References: <1403108063-27169-1-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable To: dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1403108063-27169-1-git-send-email-declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Adding support to rte_eth_dev_data structure to support unique name identifier for ethdevs to support adding slave ethdevs (specifically virtual devices which have no public unique identifier) to a link bonding device. This changes the API rte_eth_dev_allocate() to require a const char *name when allocating a ethdev, which also verifies that the name is unique and hasn=E2=80=99t been already used by an existed allocated rte_eth_dev. Also contains updates to virtual pmd=E2=80=99s to now call the API with a name parameter. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c | 32 ++++++++++++++++++++++++= +++-- lib/librte_ether/rte_ethdev.h | 7 +++++- lib/librte_pmd_pcap/rte_eth_pcap.c | 22 ++++++++++---------- lib/librte_pmd_ring/rte_eth_ring.c | 32 +++++++++++++++---------= ----- lib/librte_pmd_ring/rte_eth_ring.h | 3 +- lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 2 +- 6 files changed, 66 insertions(+), 32 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.= c index 7256841..d938603 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -65,6 +65,7 @@ #include #include #include +#include =20 #include "rte_ether.h" #include "rte_ethdev.h" @@ -153,21 +154,40 @@ rte_eth_dev_data_alloc(void) RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data)); } =20 +static struct rte_eth_dev * +rte_eth_dev_allocated(const char *name) +{ + unsigned i; + + for (i =3D 0; i < nb_ports; i++) { + if (strcmp(rte_eth_devices[i].data->name, name) =3D=3D 0) + return &rte_eth_devices[i]; + } + return NULL; +} + struct rte_eth_dev * -rte_eth_dev_allocate(void) +rte_eth_dev_allocate(const char *name) { struct rte_eth_dev *eth_dev; =20 if (nb_ports =3D=3D RTE_MAX_ETHPORTS) { - PMD_DEBUG_TRACE("Reached maximum number of ethernet ports\n"); + PMD_DEBUG_TRACE("Reached maximum number of Ethernet ports\n"); return NULL; } =20 if (rte_eth_dev_data =3D=3D NULL) rte_eth_dev_data_alloc(); =20 + if (rte_eth_dev_allocated(name) !=3D NULL) { + PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated!\n"); + return NULL; + } + eth_dev =3D &rte_eth_devices[nb_ports]; eth_dev->data =3D &rte_eth_dev_data[nb_ports]; + rte_snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), + "%s", name); eth_dev->data->port_id =3D nb_ports++; return eth_dev; } @@ -178,11 +198,17 @@ rte_eth_dev_init(struct rte_pci_driver *pci_drv, { struct eth_driver *eth_drv; struct rte_eth_dev *eth_dev; + char ethdev_name[RTE_ETH_NAME_MAX_LEN]; + int diag; =20 eth_drv =3D (struct eth_driver *)pci_drv; =20 - eth_dev =3D rte_eth_dev_allocate(); + /* Create unique Ethernet device name using PCI address */ + rte_snprintf(ethdev_name, RTE_ETH_NAME_MAX_LEN, "%d:%d.%d", + pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); + + eth_dev =3D rte_eth_dev_allocate(ethdev_name); if (eth_dev =3D=3D NULL) return -ENOMEM; =20 diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h index 2406e45..50df654 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -1497,6 +1497,8 @@ struct rte_eth_dev_sriov { }; #define RTE_ETH_DEV_SRIOV(dev) ((dev)->data->sriov) =20 +#define RTE_ETH_NAME_MAX_LEN (32) + /** * @internal * The data part, with no function pointers, associated with each ethern= et device. @@ -1505,6 +1507,8 @@ struct rte_eth_dev_sriov { * processes in a multi-process configuration. */ struct rte_eth_dev_data { + char name[RTE_ETH_NAME_MAX_LEN]; /**< Unique identifier name */ + void **rx_queues; /**< Array of pointers to RX queues. */ void **tx_queues; /**< Array of pointers to TX queues. */ uint16_t nb_rx_queues; /**< Number of RX queues. */ @@ -1560,10 +1564,11 @@ extern uint8_t rte_eth_dev_count(void); * Allocates a new ethdev slot for an ethernet device and returns the po= inter * to that slot for the driver to use. * + * @param name Unique identifier name for each Ethernet device * @return * - Slot in the rte_dev_devices array for a new device; */ -struct rte_eth_dev *rte_eth_dev_allocate(void); +struct rte_eth_dev *rte_eth_dev_allocate(const char *name); =20 struct eth_driver; /** diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c b/lib/librte_pmd_pcap/rte= _eth_pcap.c index b3dbbda..12b7e0c 100644 --- a/lib/librte_pmd_pcap/rte_eth_pcap.c +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c @@ -534,7 +534,7 @@ open_tx_iface(const char *key __rte_unused, const cha= r *value, void *extra_args) =20 =20 static int -rte_pmd_init_internals(const unsigned nb_rx_queues, +rte_pmd_init_internals(const char *name, const unsigned nb_rx_queues, const unsigned nb_tx_queues, const unsigned numa_node, struct pmd_internals **internals, @@ -558,20 +558,20 @@ rte_pmd_init_internals(const unsigned nb_rx_queues, /* now do all data allocation - for eth_dev structure, dummy pci driver * and internal (private) data */ - data =3D rte_zmalloc_socket(NULL, sizeof(*data), 0, numa_node); + data =3D rte_zmalloc_socket(name, sizeof(*data), 0, numa_node); if (data =3D=3D NULL) goto error; =20 - pci_dev =3D rte_zmalloc_socket(NULL, sizeof(*pci_dev), 0, numa_node); + pci_dev =3D rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node); if (pci_dev =3D=3D NULL) goto error; =20 - *internals =3D rte_zmalloc_socket(NULL, sizeof(**internals), 0, numa_no= de); + *internals =3D rte_zmalloc_socket(name, sizeof(**internals), 0, numa_no= de); if (*internals =3D=3D NULL) goto error; =20 /* reserve an ethdev entry */ - *eth_dev =3D rte_eth_dev_allocate(); + *eth_dev =3D rte_eth_dev_allocate(name); if (*eth_dev =3D=3D NULL) goto error; =20 @@ -617,7 +617,7 @@ rte_pmd_init_internals(const unsigned nb_rx_queues, } =20 static int -rte_eth_from_pcaps_n_dumpers(pcap_t * const rx_queues[], +rte_eth_from_pcaps_n_dumpers(const char *name, pcap_t * const rx_queues[= ], const unsigned nb_rx_queues, pcap_dumper_t * const tx_queues[], const unsigned nb_tx_queues, @@ -634,7 +634,7 @@ rte_eth_from_pcaps_n_dumpers(pcap_t * const rx_queues= [], if (tx_queues =3D=3D NULL && nb_tx_queues > 0) return -1; =20 - if (rte_pmd_init_internals(nb_rx_queues, nb_tx_queues, numa_node, + if (rte_pmd_init_internals(name, nb_rx_queues, nb_tx_queues, numa_node, &internals, ð_dev, kvlist) < 0) return -1; =20 @@ -652,7 +652,7 @@ rte_eth_from_pcaps_n_dumpers(pcap_t * const rx_queues= [], } =20 static int -rte_eth_from_pcaps(pcap_t * const rx_queues[], +rte_eth_from_pcaps(const char *name, pcap_t * const rx_queues[], const unsigned nb_rx_queues, pcap_t * const tx_queues[], const unsigned nb_tx_queues, @@ -669,7 +669,7 @@ rte_eth_from_pcaps(pcap_t * const rx_queues[], if (tx_queues =3D=3D NULL && nb_tx_queues > 0) return -1; =20 - if (rte_pmd_init_internals(nb_rx_queues, nb_tx_queues, numa_node, + if (rte_pmd_init_internals(name, nb_rx_queues, nb_tx_queues, numa_node, &internals, ð_dev, kvlist) < 0) return -1; =20 @@ -760,10 +760,10 @@ rte_pmd_pcap_devinit(const char *name, const char *= params) return -1; =20 if (using_dumpers) - return rte_eth_from_pcaps_n_dumpers(pcaps.pcaps, pcaps.num_of_rx, + return rte_eth_from_pcaps_n_dumpers(name, pcaps.pcaps, pcaps.num_of_rx= , dumpers.dumpers, dumpers.num_of_tx, numa_node, kvlist); =20 - return rte_eth_from_pcaps(pcaps.pcaps, pcaps.num_of_rx, dumpers.pcaps, + return rte_eth_from_pcaps(name, pcaps.pcaps, pcaps.num_of_rx, dumpers.p= caps, dumpers.num_of_tx, numa_node, kvlist); =20 } diff --git a/lib/librte_pmd_ring/rte_eth_ring.c b/lib/librte_pmd_ring/rte= _eth_ring.c index 10d4e24..f9174f1 100644 --- a/lib/librte_pmd_ring/rte_eth_ring.c +++ b/lib/librte_pmd_ring/rte_eth_ring.c @@ -219,7 +219,7 @@ static struct eth_dev_ops ops =3D { }; =20 int -rte_eth_from_rings(struct rte_ring *const rx_queues[], +rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[], const unsigned nb_rx_queues, struct rte_ring *const tx_queues[], const unsigned nb_tx_queues, @@ -243,20 +243,20 @@ rte_eth_from_rings(struct rte_ring *const rx_queues= [], /* now do all data allocation - for eth_dev structure, dummy pci driver * and internal (private) data */ - data =3D rte_zmalloc_socket(NULL, sizeof(*data), 0, numa_node); + data =3D rte_zmalloc_socket(name, sizeof(*data), 0, numa_node); if (data =3D=3D NULL) goto error; =20 - pci_dev =3D rte_zmalloc_socket(NULL, sizeof(*pci_dev), 0, numa_node); + pci_dev =3D rte_zmalloc_socket(name, sizeof(*pci_dev), 0, numa_node); if (pci_dev =3D=3D NULL) goto error; =20 - internals =3D rte_zmalloc_socket(NULL, sizeof(*internals), 0, numa_node= ); + internals =3D rte_zmalloc_socket(name, sizeof(*internals), 0, numa_node= ); if (internals =3D=3D NULL) goto error; =20 /* reserve an ethdev entry */ - eth_dev =3D rte_eth_dev_allocate(); + eth_dev =3D rte_eth_dev_allocate(name); if (eth_dev =3D=3D NULL) goto error; =20 @@ -335,7 +335,7 @@ eth_dev_ring_create(const char *name, const unsigned = numa_node, return -1; } =20 - if (rte_eth_from_rings(rxtx, num_rings, rxtx, num_rings, numa_node)) + if (rte_eth_from_rings(name, rxtx, num_rings, rxtx, num_rings, numa_nod= e)) return -1; =20 return 0; @@ -352,29 +352,31 @@ eth_dev_ring_pair_create(const char *name, const un= signed numa_node, struct rte_ring *rx[RTE_PMD_RING_MAX_RX_RINGS]; struct rte_ring *tx[RTE_PMD_RING_MAX_TX_RINGS]; unsigned i; - char rng_name[RTE_RING_NAMESIZE]; + char rx_rng_name[RTE_RING_NAMESIZE]; + char tx_rng_name[RTE_RING_NAMESIZE]; unsigned num_rings =3D RTE_MIN(RTE_PMD_RING_MAX_RX_RINGS, RTE_PMD_RING_MAX_TX_RINGS); =20 for (i =3D 0; i < num_rings; i++) { - rte_snprintf(rng_name, sizeof(rng_name), "ETH_RX%u_%s", i, name); + rte_snprintf(rx_rng_name, sizeof(rx_rng_name), "ETH_RX%u_%s", i, name)= ; rx[i] =3D (action =3D=3D DEV_CREATE) ? - rte_ring_create(rng_name, 1024, numa_node, + rte_ring_create(rx_rng_name, 1024, numa_node, RING_F_SP_ENQ|RING_F_SC_DEQ) : - rte_ring_lookup(rng_name); + rte_ring_lookup(rx_rng_name); if (rx[i] =3D=3D NULL) return -1; - rte_snprintf(rng_name, sizeof(rng_name), "ETH_TX%u_%s", i, name); + rte_snprintf(tx_rng_name, sizeof(tx_rng_name), "ETH_TX%u_%s", i, name)= ; tx[i] =3D (action =3D=3D DEV_CREATE) ? - rte_ring_create(rng_name, 1024, numa_node, + rte_ring_create(tx_rng_name, 1024, numa_node, RING_F_SP_ENQ|RING_F_SC_DEQ): - rte_ring_lookup(rng_name); + rte_ring_lookup(tx_rng_name); if (tx[i] =3D=3D NULL) return -1; } =20 - if (rte_eth_from_rings(rx, num_rings, tx, num_rings, numa_node) || - rte_eth_from_rings(tx, num_rings, rx, num_rings, numa_node) ) + if (rte_eth_from_rings(rx_rng_name, rx, num_rings, tx, num_rings, + numa_node) || rte_eth_from_rings(tx_rng_name, tx, num_rings, rx, + num_rings, numa_node)) return -1; =20 return 0; diff --git a/lib/librte_pmd_ring/rte_eth_ring.h b/lib/librte_pmd_ring/rte= _eth_ring.h index ef29344..e6ae19e 100644 --- a/lib/librte_pmd_ring/rte_eth_ring.h +++ b/lib/librte_pmd_ring/rte_eth_ring.h @@ -40,7 +40,8 @@ extern "C" { =20 #include =20 -int rte_eth_from_rings(struct rte_ring * const rx_queues[], +int rte_eth_from_rings(const char *name, + struct rte_ring * const rx_queues[], const unsigned nb_rx_queues, struct rte_ring *const tx_queues[], const unsigned nb_tx_queues, diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c b/lib/librte_pmd_xe= nvirt/rte_eth_xenvirt.c index 7c4d3fe..a0b4bdd 100644 --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c @@ -647,7 +647,7 @@ eth_dev_xenvirt_create(const char *name, const char *= params, goto err; =20 /* reserve an ethdev entry */ - eth_dev =3D rte_eth_dev_allocate(); + eth_dev =3D rte_eth_dev_allocate(name); if (eth_dev =3D=3D NULL) goto err; =20 --=20 1.7.0.7