From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 24 Jun 2014 19:36:15 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:41486 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6855641AbaFXRbxOtJjd (ORCPT ); Tue, 24 Jun 2014 19:31:53 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 03A4DBEF710A2; Tue, 24 Jun 2014 18:31:44 +0100 (IST) Received: from hhmail02.hh.imgtec.org (10.100.10.20) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.181.6; Tue, 24 Jun 2014 18:31:46 +0100 Received: from BAMAIL02.ba.imgtec.org (192.168.66.28) by hhmail02.hh.imgtec.org (10.100.10.20) with Microsoft SMTP Server (TLS) id 14.3.181.6; Tue, 24 Jun 2014 18:31:46 +0100 Received: from fun-lab.mips.com (10.20.2.221) by bamail02.ba.imgtec.org (192.168.66.28) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 24 Jun 2014 10:31:44 -0700 From: Deng-Cheng Zhu To: CC: , , , , , , Subject: [PATCH v3 9/9] MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr() Date: Tue, 24 Jun 2014 10:31:10 -0700 Message-ID: <1403631071-6012-10-git-send-email-dengcheng.zhu@imgtec.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.20.2.221] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 40752 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dengcheng.zhu@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips From: James Hogan It's impossible to fall into the error handling of the TLB index after being masked by (KVM_MIPS_GUEST_TLB_SIZE - 1). Remove the dead code. Signed-off-by: James Hogan Signed-off-by: Deng-Cheng Zhu --- arch/mips/kvm/emulate.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c index 982f4af..5500fef 100644 --- a/arch/mips/kvm/emulate.c +++ b/arch/mips/kvm/emulate.c @@ -846,11 +846,6 @@ enum emulation_result kvm_mips_emul_tlbwr(struct kvm_vcpu *vcpu) get_random_bytes(&index, sizeof(index)); index &= (KVM_MIPS_GUEST_TLB_SIZE - 1); - if (index < 0 || index >= KVM_MIPS_GUEST_TLB_SIZE) { - kvm_err("%s: illegal index: %d\n", __func__, index); - return EMULATE_FAIL; - } - tlb = &vcpu->arch.guest_tlb[index]; /* -- 1.8.5.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:41486 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6855641AbaFXRbxOtJjd (ORCPT ); Tue, 24 Jun 2014 19:31:53 +0200 From: Deng-Cheng Zhu Subject: [PATCH v3 9/9] MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr() Date: Tue, 24 Jun 2014 10:31:10 -0700 Message-ID: <1403631071-6012-10-git-send-email-dengcheng.zhu@imgtec.com> In-Reply-To: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: pbonzini@redhat.com Cc: gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com, james.hogan@imgtec.com, ralf@linux-mips.org, linux-mips@linux-mips.org, dengcheng.zhu@imgtec.com Message-ID: <20140624173110.YtjF-4GDLxTzSp6ZOzzNGg0-kG_5i6CbD3CIHZHzkbw@z> From: James Hogan It's impossible to fall into the error handling of the TLB index after being masked by (KVM_MIPS_GUEST_TLB_SIZE - 1). Remove the dead code. Signed-off-by: James Hogan Signed-off-by: Deng-Cheng Zhu --- arch/mips/kvm/emulate.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c index 982f4af..5500fef 100644 --- a/arch/mips/kvm/emulate.c +++ b/arch/mips/kvm/emulate.c @@ -846,11 +846,6 @@ enum emulation_result kvm_mips_emul_tlbwr(struct kvm_vcpu *vcpu) get_random_bytes(&index, sizeof(index)); index &= (KVM_MIPS_GUEST_TLB_SIZE - 1); - if (index < 0 || index >= KVM_MIPS_GUEST_TLB_SIZE) { - kvm_err("%s: illegal index: %d\n", __func__, index); - return EMULATE_FAIL; - } - tlb = &vcpu->arch.guest_tlb[index]; /* -- 1.8.5.3