From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH ARM v5 17/20] mini-os: headers for ARM
Date: Fri, 27 Jun 2014 14:11:07 +0100
Message-ID: <1403874667.3169.31.camel@kazak.uk.xensource.com>
References: <1403782117-15125-1-git-send-email-talex5@gmail.com>
	<1403782117-15125-18-git-send-email-talex5@gmail.com>
	<53AC499C.6090004@linaro.org>
	<CAG4opy-6vXRPA=JcKRA1gm8-J8_BzUREkPj6D=XsA5jEKLasyA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1X0VwM-0002Zi-2g
	for xen-devel@lists.xenproject.org; Fri, 27 Jun 2014 13:11:42 +0000
In-Reply-To: <CAG4opy-6vXRPA=JcKRA1gm8-J8_BzUREkPj6D=XsA5jEKLasyA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>
Cc: David Scott <Dave.Scott@eu.citrix.com>, Anil Madhavapeddy <anil@recoil.org>, Julien Grall <julien.grall@linaro.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>, xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-06-27 at 14:02 +0100, Thomas Leonard wrote:

> >> +#define BUG() while(1){}
> >
> > It looks odd to use onely while (1). Shouldn't you call do_exit as x86 does?
> 
> Note that patch #20 changes this to dump the registers and stack.
> 
> [ also, exiting on BUG is annoying because you may lose the console
> output if the VM dies before xl attaches to it. ]

That's what on_crash=preserve and xenconsoled's logging capabilities are
for. I expect SCHEDOP_crash is probably better than exiting though.

Ian.