All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: Samuel Chessman <chessman@tux.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 04/11] tlan: Fix MAC address byte order on OC-2325/OC-2326
Date: Mon, 30 Jun 2014 18:38:30 +0200	[thread overview]
Message-ID: <1404146317-3094-5-git-send-email-linux@rainbow-software.org> (raw)
In-Reply-To: <1404146317-3094-1-git-send-email-linux@rainbow-software.org>

Olicom OC-2325 and OC-2326 cards have the MAC address byte-swapped in EEPROM.
Byte-swap the MAC address if it's located at offset 0xF8.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
 drivers/net/ethernet/ti/tlan.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index ae9fece..31d4a96 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -864,7 +864,7 @@ static int tlan_init(struct net_device *dev)
 		priv->rx_list_dma + sizeof(struct tlan_list)*TLAN_NUM_RX_LISTS;
 
 	err = 0;
-	for (i = 0;  i < 6 ; i++)
+	for (i = 0; i < ETH_ALEN; i++)
 		err |= tlan_ee_read_byte(dev,
 					 (u8) priv->adapter->addr_ofs + i,
 					 (u8 *) &dev->dev_addr[i]);
@@ -872,7 +872,14 @@ static int tlan_init(struct net_device *dev)
 		pr_err("%s: Error reading MAC from eeprom: %d\n",
 		       dev->name, err);
 	}
-	dev->addr_len = 6;
+	/* Olicom OC-2325/OC-2326 have the address byte-swapped */
+	if (priv->adapter->addr_ofs == 0xf8) {
+		for (i = 0; i < ETH_ALEN; i += 2) {
+			char tmp = dev->dev_addr[i];
+			dev->dev_addr[i] = dev->dev_addr[i + 1];
+			dev->dev_addr[i + 1] = tmp;
+		}
+	}
 
 	netif_carrier_off(dev);
 
-- 
Ondrej Zary


  parent reply	other threads:[~2014-06-30 16:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 16:38 [PATCH 0/11 v3] tlan: Link handling improvements and Olicom fixes Ondrej Zary
2014-06-30 16:38 ` [PATCH 01/11] tlan: Enable activity LED on Olicom OC-2325 and OC-2326 Ondrej Zary
2014-06-30 16:38 ` [PATCH 02/11] tlan: Enable link monitoring Ondrej Zary
2014-06-30 16:38 ` [PATCH 03/11] tlan: Add ethtool support Ondrej Zary
2014-06-30 16:38 ` Ondrej Zary [this message]
2014-06-30 16:38 ` [PATCH 05/11] tlan: Restart autonegotiation on link loss Ondrej Zary
2014-06-30 16:38 ` [PATCH 06/11] tlan: Don't scream if no link Ondrej Zary
2014-06-30 16:38 ` [PATCH 07/11] tlan: Make autonegotiation faster Ondrej Zary
2014-06-30 16:38 ` [PATCH 08/11] tlan: Add PHY reset timeout Ondrej Zary
2014-06-30 16:38 ` [PATCH 09/11] tlan: Don't disable internal PHY on cards that use it in 10 Mbps mode Ondrej Zary
2014-06-30 16:38 ` [PATCH 10/11] tlan: Enable device at resume Ondrej Zary
2014-06-30 16:38 ` [PATCH 11/11] tlan: Isolate external PHY when using internal PHY Ondrej Zary
2014-07-08  0:09 ` [PATCH 0/11 v3] tlan: Link handling improvements and Olicom fixes David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-06-21 14:47 [PATCH 0/11 v2] " Ondrej Zary
2014-06-21 14:47 ` [PATCH 04/11] tlan: Fix MAC address byte order on OC-2325/OC-2326 Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404146317-3094-5-git-send-email-linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=chessman@tux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.