From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH ARM v5 19/20] mini-os: initial ARM support
Date: Wed, 2 Jul 2014 09:23:01 +0100
Message-ID: <1404289381.26896.22.camel@kazak.uk.xensource.com>
References: <1403782117-15125-1-git-send-email-talex5@gmail.com>
	<1403782117-15125-20-git-send-email-talex5@gmail.com>
	<53AF0A0E.6000504@linaro.org>
	<CAG4opy_DS8t8J-Ha1s8gozXNgUGguZs0D8FdZDWu6yy1Gp4YMQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1X2Foo-0007Wm-P7
	for xen-devel@lists.xenproject.org; Wed, 02 Jul 2014 08:23:06 +0000
In-Reply-To: <CAG4opy_DS8t8J-Ha1s8gozXNgUGguZs0D8FdZDWu6yy1Gp4YMQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>
Cc: David Scott <Dave.Scott@eu.citrix.com>, Anil Madhavapeddy <anil@recoil.org>, Julien Grall <julien.grall@linaro.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>, xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-06-30 at 20:12 +0100, Thomas Leonard wrote:
> > IHMO all these changes doesn't belong to the commit message, i.e should not
> > appear in the commit message when Ian will apply your commit message.
> 
> As I understand it, as I'm not the author of the patch, it's polite to
> indicate how I have modified it. I'm trying to follow the guidelines
> here:

I'm not suggesting you change what you've done here at this stage, but
for next time:

It's a bit of a judgement call based on the scale of the changes. For
the number of changes you have done I might have considered making
myself the "Author" and saying in the commit log "Based on an initial
patch by Karim, but heavily modified, bugs are all mine" or something
along those lines etc.

Or if you felt your changes weren't sufficient to justify a change of
the primary author then a single "Extensively/slightly* modified" (*
delete as applicable) note would be OK.

The full intra-patch changelog could still usefully go after the "---"
break to aid reviewers.

Ian.