From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc@hellion.org.uk>
Date: Mon, 07 Jul 2014 16:10:42 +0100
Subject: [U-Boot] [PATCH v3 00/10] sunxi: Bug fixes,
 sun4i and sun5i support and network improvements
In-Reply-To: <53BA97A6.1000901@redhat.com>
References: <1402306622-18485-1-git-send-email-hdegoede@redhat.com>
	<1404673937.4003.6.camel@hastur.hellion.org.uk>
	<53BA97A6.1000901@redhat.com>
Message-ID: <1404745842.30778.37.camel@kazak.uk.xensource.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2014-07-07 at 14:50 +0200, Hans de Goede wrote:
> AFAIK we will never define both EMAC and GMAC for the same board,

If we are sure of this (and I suspect this is the case, since IIRC they
share some pins) then I agree with your suggestion.

> so IMHO a better fix would be to change this line:
> 
>   	rc = sunxi_emac_initialize(bis);
> 
> to:
> 
>   	int rc = sunxi_emac_initialize(bis);
> 
> And the same for gmac.
> 
> Regards,
> 
> Hans
> 
> 
> 
> 
>