From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbaGHGNK (ORCPT ); Tue, 8 Jul 2014 02:13:10 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:34891 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922AbaGHGNF (ORCPT ); Tue, 8 Jul 2014 02:13:05 -0400 Message-ID: <1404799979.3515.0.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH] appletalk: Fix socket referencing in skb From: Eric Dumazet To: Andrey Utkin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, acme@ghostprotocols.net, davem@davemloft.net Date: Tue, 08 Jul 2014 08:12:59 +0200 In-Reply-To: <1404764570-24120-1-git-send-email-andrey.krieger.utkin@gmail.com> References: <1404764570-24120-1-git-send-email-andrey.krieger.utkin@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-07-07 at 23:22 +0300, Andrey Utkin wrote: > Setting just skb->sk without taking its reference and setting a > destructor is invalid. However, in the places where this was done, skb > is used in a way not requiring skb->sk setting. So dropping the setting > of skb->sk. > Thanks to Eric Dumazet for correct solution. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79441 > Reported-by: Ed Martin > Signed-off-by: Andrey Utkin > --- Thanks ! Signed-off-by: Eric Dumazet From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Date: Tue, 08 Jul 2014 06:12:59 +0000 Subject: Re: [PATCH] appletalk: Fix socket referencing in skb Message-Id: <1404799979.3515.0.camel@edumazet-glaptop2.roam.corp.google.com> List-Id: References: <1404764570-24120-1-git-send-email-andrey.krieger.utkin@gmail.com> In-Reply-To: <1404764570-24120-1-git-send-email-andrey.krieger.utkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrey Utkin Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, acme@ghostprotocols.net, davem@davemloft.net On Mon, 2014-07-07 at 23:22 +0300, Andrey Utkin wrote: > Setting just skb->sk without taking its reference and setting a > destructor is invalid. However, in the places where this was done, skb > is used in a way not requiring skb->sk setting. So dropping the setting > of skb->sk. > Thanks to Eric Dumazet for correct solution. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?idy441 > Reported-by: Ed Martin > Signed-off-by: Andrey Utkin > --- Thanks ! Signed-off-by: Eric Dumazet