From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [memnic PATCH v2] pmd: fix race condition
Date: Fri, 11 Apr 2014 17:46:24 +0200
Message-ID: <1404995.PT3YR8Coxx@xps13>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD0109D398@BPXM14GP.gisp.nec.co.jp>
 <7724767.rVnlBRSiNS@platinum>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org, Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
To: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <7724767.rVnlBRSiNS@platinum>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-04-11 16:41, Olivier MATZ:
> On Thursday, April 03, 2014 06:35:06 AM Hiroshi Shimamoto wrote:
> > From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> > 
> > There is a race condition, on transmit to host.
> > 
> > Guest PMD                 Host
> > Thread-A     Thread-B     vSwitch
> > 
> >    |idx=0       |idx=0       |p[0] st!=2
> >    |cmpxchg     |            |
> >    |p[0] st->1  |            |
> >    |idx=1       |            |
> >    |fill data   |            |
> >    |p[0] st->2  |            |p[0] st==2
> >    |
> >    |            |            |receive data
> >    |            |            |p[0] st->0
> >    |            |
> >    |            |cmpxchg     |
> >    |            |success     |p[1] st!=2
> >    |            |p[0] st->1  |
> >    |            |
> >                   This is BAD
> > 
> > That causes traffic stop.
> > 
> > We have to take care about that race condition with checking
> > whether current index is correct.
> > 
> > Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> > Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
> 
> Reviewed-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied

Thanks
-- 
Thomas