From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [RFC PATCH v2 6/7] Changed slice to budget in libxc
 for the sedf scheduler
Date: Thu, 10 Jul 2014 15:15:25 +0100
Message-ID: <1405001725.24434.24.camel@kazak.uk.xensource.com>
References: <1404939348-4926-1-git-send-email-josh.whitehead@dornerworks.com>
	<1404939348-4926-7-git-send-email-josh.whitehead@dornerworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1404939348-4926-7-git-send-email-josh.whitehead@dornerworks.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Josh Whitehead <josh.whitehead@dornerworks.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, Xen-devel <xen-devel@lists.xen.org>, Nathan Studer <nate.studer@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@dornerworks.com>
> 
> Signed-off-by: Robert VanVossen <Robert.VanVossen@dornerworks.com>
> Signed-off-by: Nathan Studer <nate.studer@gmail.com>
> 
> ---
>  tools/libxc/xc_sedf.c             |    8 ++++----
>  tools/libxc/xenctrl.h             |    4 ++--
>  tools/python/xen/lowlevel/xc/xc.c |   20 ++++++++++----------
>  xen/include/public/domctl.h       |    2 +-
>  4 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/tools/libxc/xc_sedf.c b/tools/libxc/xc_sedf.c
> index 81ff133..ab67546 100644
> --- a/tools/libxc/xc_sedf.c
> +++ b/tools/libxc/xc_sedf.c
> @@ -28,7 +28,7 @@ int xc_sedf_domain_set(
>      xc_interface *xch,
>      uint32_t domid,
>      uint64_t period,
> -    uint64_t slice,
> +    uint64_t budget,

Isn't the going to break the libxl behaviour between this patch and the
next one?

I think it is unavoidable to change this interface and the libxl one at
the same time.

If there is sensible default budget then perhaps you could change libxl
to use that unconditionally in this patch and then do all the plumbing
out to the libxl API and into xl in the next patch.

Ian.