From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [RFC PATCH v2 5/7] Add cbs parameter support and
 removed sedf parameters with a LIBXL_API_VERSION gate from libxl.
Date: Thu, 10 Jul 2014 16:26:59 +0200
Message-ID: <1405002419.29306.52.camel@Solace>
References: <1404939348-4926-1-git-send-email-josh.whitehead@dornerworks.com>
	<1404939348-4926-6-git-send-email-josh.whitehead@dornerworks.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3472426158254154781=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1404939348-4926-6-git-send-email-josh.whitehead@dornerworks.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Josh Whitehead <josh.whitehead@dornerworks.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>, Xen-devel <xen-devel@lists.xen.org>, Nathan Studer <nate.studer@gmail.com>
List-Id: xen-devel@lists.xenproject.org

--===============3472426158254154781==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-e0G2C58y4LAT6aOv6/42"

--=-e0G2C58y4LAT6aOv6/42
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@dornerworks.com>
>=20
> We made an attempt at doing the versioning gate in this file.  Please let=
 us
> know if further changes are needed, and where they are needed to properly=
 guard
> the API.
>=20
So, since you're adding soft to libxl_domain_sched_params, so you need
to add something like:

/*
 * Some comments...
 */
#define LIBXL_HAVE_DOMAIN_SCHED_PARAMS_SOFT 1

in libxl.h.

Look at LIBXL_HAVE_DOMAIN_NODEAFFINITY,
LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY for inspiration. :-)

If it were me, I think I'd include _SEDF_ in the name as well:

#define LIBXL_HAVE_DOMAIN_SCHED_SEDF_PARAMS_SOFT 1

or:

#define LIBXL_HAVE_DOMAIN_SCHEDPARAM_SEDF_SOFT 1

And I now see that Ian said plenty already in his email about
LIBXL_API_VERSION. I'll continue there...

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-e0G2C58y4LAT6aOv6/42
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlO+orMACgkQk4XaBE3IOsR5OQCdFTaBcQOujhMMl04s/p6mRq7M
l6cAnjhWelnY5zmxBEE3ufkXByvRC6Zc
=75gI
-----END PGP SIGNATURE-----

--=-e0G2C58y4LAT6aOv6/42--


--===============3472426158254154781==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3472426158254154781==--