From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: Introduce rt real-time scheduler for Xen
Date: Fri, 11 Jul 2014 13:06:48 +0200
Message-ID: <1405076808.29306.397.camel@Solace>
References: <1405054198-29106-1-git-send-email-mengxu@cis.upenn.edu>
	<20140711105032.GC12584@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7826374392070239079=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140711105032.GC12584@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, xumengpanda@gmail.com, Meng Xu <mengxu@cis.upenn.edu>, lichong659@gmail.com, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============7826374392070239079==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-A0YWoUOZ4fx0IKIreSrZ"

--=-A0YWoUOZ4fx0IKIreSrZ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On ven, 2014-07-11 at 11:50 +0100, Wei Liu wrote:
> On Fri, Jul 11, 2014 at 12:49:54AM -0400, Meng Xu wrote:
> [...]
> >=20
> > [PATCH RFC v1 1/4] rt: Add rt scheduler to hypervisor
> > [PATCH RFC v1 2/4] xl for rt scheduler
> > [PATCH RFC v1 3/4] libxl for rt scheduler
> > [PATCH RFC v1 4/4] libxc for rt scheduler
> >=20
>=20
> I have some general comments on how you arrange these patches.
>=20
> At a glance of the title and code you should do them in the order of 1,
> 4, 3 and 2. Apparently xl depends on libxl, libxl depends on libxc, and
> libxc depends on hypervisor. You will break bisection with current
> ordering.
>=20
Yep, I agree with Wei.

> And we normally write titles like
>   xen: add rt scheduler
>   libxl: introduce rt scheduler
>   xl: XXXX
>   etc.
> start with component name and separate with colon.
>=20
Indeed we do, and this helps quite a bit.

> Last but not least, you need to CC relevant maintainers. You can find
> out maintainers with scripts/get_maintainers.pl.
>=20
Yes, but this one, Meng almost got it right, I think.

Basically, Meng, you're missing hypervisors maintainers (at least for
patch 1). :-)

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-A0YWoUOZ4fx0IKIreSrZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlO/xUgACgkQk4XaBE3IOsRYlgCfSxgfoyf/lM5SpaTtiY0fRt8h
gpkAn269O2HK2YP0R+/YhZz7jOznRak1
=4zvO
-----END PGP SIGNATURE-----

--=-A0YWoUOZ4fx0IKIreSrZ--


--===============7826374392070239079==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7826374392070239079==--