From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com,
oleg@redhat.com, sbw@mit.edu,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 2/2] rcu: Don't offload callbacks unless specifically requested
Date: Fri, 11 Jul 2014 06:35:03 -0700 [thread overview]
Message-ID: <1405085703-14822-2-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1405085703-14822-1-git-send-email-paulmck@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Enabling NO_HZ_FULL currently has the side effect of enabling callback
offloading on all CPUs. This results in lots of additional rcuo kthreads,
and can also increase context switching and wakeups, even in cases where
callback offloading is neither needed nor particularly desirable. This
commit therefore enables callback offloading on a given CPU only if
specifically requested at build time or boot time, or if that CPU has
been specifically designated (again, either at build time or boot time)
as a nohz_full CPU.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
init/Kconfig | 4 ++--
kernel/rcu/tree_plugin.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index 9d76b99af1b9..9332d33346ac 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -737,7 +737,7 @@ choice
config RCU_NOCB_CPU_NONE
bool "No build_forced no-CBs CPUs"
- depends on RCU_NOCB_CPU && !NO_HZ_FULL
+ depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
help
This option does not force any of the CPUs to be no-CBs CPUs.
Only CPUs designated by the rcu_nocbs= boot parameter will be
@@ -751,7 +751,7 @@ config RCU_NOCB_CPU_NONE
config RCU_NOCB_CPU_ZERO
bool "CPU 0 is a build_forced no-CBs CPU"
- depends on RCU_NOCB_CPU && !NO_HZ_FULL
+ depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
help
This option forces CPU 0 to be a no-CBs CPU, so that its RCU
callbacks are invoked by a per-CPU kthread whose name begins
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index b27b86c7bbfa..17eed0856b03 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -2473,6 +2473,9 @@ static void __init rcu_spawn_nocb_kthreads(struct rcu_state *rsp)
if (rcu_nocb_mask == NULL)
return;
+#ifdef CONFIG_NO_HZ_FULL
+ cpumask_or(rcu_nocb_mask, rcu_nocb_mask, tick_nohz_full_mask);
+#endif /* #ifdef CONFIG_NO_HZ_FULL */
if (ls == -1) {
ls = int_sqrt(nr_cpu_ids);
rcu_nocb_leader_stride = ls;
--
1.8.1.5
next prev parent reply other threads:[~2014-07-11 13:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 22:48 [PATCH tip/core/rcu 0/2] Callback-offloading changes for 3.17 Paul E. McKenney
2014-07-11 13:35 ` [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups Paul E. McKenney
2014-07-11 13:35 ` Paul E. McKenney [this message]
2014-07-11 13:47 ` [PATCH tip/core/rcu 2/2] rcu: Don't offload callbacks unless specifically requested Frederic Weisbecker
2014-07-11 15:28 ` Paul E. McKenney
2014-08-08 8:40 ` [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups Amit Shah
2014-08-08 16:25 ` Paul E. McKenney
2014-08-08 17:37 ` Amit Shah
2014-08-08 18:18 ` Paul E. McKenney
2014-08-08 18:34 ` Amit Shah
2014-08-08 21:43 ` Paul E. McKenney
2014-08-08 21:46 ` Paul E. McKenney
2014-08-11 7:13 ` Amit Shah
2014-08-11 16:28 ` Paul E. McKenney
2014-08-11 19:41 ` Amit Shah
2014-08-11 20:11 ` Paul E. McKenney
2014-08-11 20:18 ` Amit Shah
2014-08-11 20:34 ` Paul E. McKenney
2014-08-12 3:45 ` Paul E. McKenney
2014-08-12 5:33 ` Amit Shah
2014-08-12 16:06 ` Paul E. McKenney
2014-08-12 21:39 ` Paul E. McKenney
2014-08-12 21:41 ` Paul E. McKenney
2014-08-12 21:44 ` Paul E. McKenney
2014-08-13 5:44 ` Amit Shah
2014-08-13 13:00 ` Paul E. McKenney
2014-08-13 14:18 ` Paul E. McKenney
2014-08-15 5:24 ` Amit Shah
2014-08-15 15:04 ` Paul E. McKenney
2014-08-18 17:53 ` Amit Shah
2014-08-19 4:01 ` Paul E. McKenney
2014-08-22 12:24 ` Amit Shah
2014-08-22 12:36 ` Amit Shah
2014-08-22 12:56 ` Amit Shah
2014-08-22 14:48 ` Paul E. McKenney
2014-08-22 17:14 ` Amit Shah
2014-08-22 17:37 ` Amit Shah
2014-08-22 21:53 ` Paul E. McKenney
2014-08-22 21:57 ` Paul E. McKenney
2014-08-22 14:43 ` Paul E. McKenney
2014-08-12 5:27 ` Amit Shah
2014-08-12 16:08 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405085703-14822-2-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=niv@us.ibm.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sbw@mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.