All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/1] arm64: dts: marvell: mcbin: reserve PSCI area
Date: Fri, 21 Dec 2018 16:37:53 +0100	[thread overview]
Message-ID: <14053482-dede-eaef-5a7b-25b2a73cfa64@denx.de> (raw)
In-Reply-To: <20181221115912.17254-1-xypron.glpk@gmx.de>

Hi Heinrich,

On 21.12.18 12:59, Heinrich Schuchardt wrote:
> The memory area [0x4000000-0x4200000[ is occupied by the PSCI firmware. Any

Nitpicking: The closing bracket is wrong above. *If* you need to re-send,
then please fix. Otherwise no need.

> attempt to access it from U-Boot leads to an immediate crash.
> 
> So let's make the same memory reservation as the vendor device tree.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> cf. https://lkml.org/lkml/2018/12/21/253
> 
> v2
> 	add missing right brace
> ---
>   arch/arm/dts/armada-8040-mcbin.dts | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/dts/armada-8040-mcbin.dts b/arch/arm/dts/armada-8040-mcbin.dts
> index f912596c2c..a039f5a790 100644
> --- a/arch/arm/dts/armada-8040-mcbin.dts
> +++ b/arch/arm/dts/armada-8040-mcbin.dts
> @@ -28,6 +28,17 @@
>   		reg = <0x0 0x0 0x0 0x80000000>;
>   	};
>   
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		psci_reserved: psci-area at 4000000 {
> +		reg = <0x0 0x4000000 0x0 0x200000>;
> +		no-map;
> +		};
> +	};
> +

I'm wondering if this reservation is only necessary and at this address
for the mcbin or also for other (or even all) Armada 7k/8k boards? If
global, then it would be better to move this reservation to a common
dtsi file instead.

Thanks,
Stefan

  reply	other threads:[~2018-12-21 15:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-21 11:59 [U-Boot] [PATCH v2 1/1] arm64: dts: marvell: mcbin: reserve PSCI area Heinrich Schuchardt
2018-12-21 15:37 ` Stefan Roese [this message]
2018-12-21 16:03   ` Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14053482-dede-eaef-5a7b-25b2a73cfa64@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.