From: Artem Bityutskiy <dedekind1@gmail.com>
To: hujianyang <hujianyang@huawei.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 6/7] New utility ubidump
Date: Wed, 16 Jul 2014 11:05:07 +0300 [thread overview]
Message-ID: <1405497907.1920.27.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <53BA4B98.1080000@huawei.com>
On Mon, 2014-07-07 at 15:26 +0800, hujianyang wrote:
> +"-h, --help print help message\n"
> +"-n, --lnum logic eraseblock num to dump\n"
I envision that in the future people may want to specify PEB number
instead of LEB number, and '-n' becomes a confusing name for the option.
Could you please only support '--lnum', and drop '-n' altogether. Then
in the future someone may add '--pnum' support.
> +"-i, --info show explicit information about NODEs\n"
I do not understand what this means from the description. Would you
please try to describe it better in the help text?
> +"-H, --header show only header information\n"
> +"-N, --node show only NODEs information\n"
Same for these.
Thanks!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-07-16 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 7:15 [PATCH RFC] ubi-utils: Add a new utility ubidump hujianyang
2014-07-07 7:17 ` [PATCH 1/7] UBI: Add a new ioctl to support ubidump hujianyang
2014-07-16 7:59 ` Artem Bityutskiy
2014-07-16 8:47 ` hujianyang
2014-07-16 10:30 ` Artem Bityutskiy
2014-07-07 7:19 ` [PATCH 2/7] Add new ioctl in userspace hujianyang
2014-07-07 7:20 ` [PATCH 3/7] Add ubifs-media.h hujianyang
2014-07-07 7:22 ` [PATCH 4/7] Add libubifs.h hujianyang
2014-07-07 7:24 ` [PATCH 5/7] Add libubifs.c hujianyang
2014-07-07 7:26 ` [PATCH 6/7] New utility ubidump hujianyang
2014-07-16 8:05 ` Artem Bityutskiy [this message]
2014-07-16 8:53 ` hujianyang
2014-07-16 10:37 ` Artem Bityutskiy
2014-07-16 11:27 ` hujianyang
2014-07-16 11:37 ` Artem Bityutskiy
2014-07-16 11:43 ` Artem Bityutskiy
2014-07-16 11:57 ` hujianyang
2014-07-21 16:20 ` Bill Pringlemeir
2014-07-22 8:15 ` hujianyang
2014-07-22 15:42 ` Bill Pringlemeir
2014-07-29 9:14 ` Artem Bityutskiy
2014-07-29 10:01 ` hujianyang
2014-07-07 7:27 ` [PATCH 7/7] Compile support hujianyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405497907.1920.27.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=hujianyang@huawei.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.