From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932978AbaGPKYf (ORCPT ); Wed, 16 Jul 2014 06:24:35 -0400 Received: from cpsmtpb-ews08.kpnxchange.com ([213.75.39.13]:49668 "EHLO cpsmtpb-ews08.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932680AbaGPKYb (ORCPT ); Wed, 16 Jul 2014 06:24:31 -0400 Message-ID: <1405506268.4408.28.camel@x220> Subject: Re: [PATCH 18/19] ARM: SAMSUNG: Remove remaining legacy code From: Paul Bolle To: Tomasz Figa Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kukjin Kim , Arnd Bergmann , Olof Johansson , Marek Szyprowski , Mark Brown , Heiko =?ISO-8859-1?Q?St=FCbner?= , Tomasz Figa Date: Wed, 16 Jul 2014 12:24:28 +0200 In-Reply-To: <1404496099-26708-19-git-send-email-t.figa@samsung.com> References: <1404496099-26708-1-git-send-email-t.figa@samsung.com> <1404496099-26708-19-git-send-email-t.figa@samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 16 Jul 2014 10:24:29.0240 (UTC) FILETIME=[20520B80:01CFA0E0] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-07-04 at 19:48 +0200, Tomasz Figa wrote: > After refactoring suspend/resume, which was last part with dependencies > on legacy code, all Kconfig symbols related to Samsung ATAGS support can > be deselected and more unused code removed. This includes most of s5p-* > code as well, as s5pv210 was their last user. > > Signed-off-by: Tomasz Figa > --- And I noticed another issue as this patch showed up in linux-next (this should be the last issue for this series). > [...] > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index f8185b5..1091b0a 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig >[...] > @@ -64,31 +51,6 @@ config SAMSUNG_ATAGS > > if SAMSUNG_ATAGS > > -# options for IRQ support > - > -config S5P_IRQ > - def_bool ARCH_S5PV210 > - help > - Support common interrupt part for ARCH_S5P SoCs > - > -config S5P_EXT_INT > - bool > - help > - Use the external interrupts (other than GPIO interrupts.) > - > -config S5P_GPIO_INT > - bool > - help > - Common code for the GPIO interrupts (other than external interrupts.) > - > -# options for gpio configuration support > - > -config S5P_GPIO_DRVSTR > - bool > - help > - Internal configuration to get and set correct GPIO driver strength > - helper > - This one is used (as a macro) in drivers/gpio/gpio-samsung.c. Is a patch that touches that macro queued somewhere? > config SAMSUNG_GPIO_EXTRA > int "Number of additional GPIO pins" > default 128 if SAMSUNG_GPIO_EXTRA128 Thanks, Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 From: pebolle@tiscali.nl (Paul Bolle) Date: Wed, 16 Jul 2014 12:24:28 +0200 Subject: [PATCH 18/19] ARM: SAMSUNG: Remove remaining legacy code In-Reply-To: <1404496099-26708-19-git-send-email-t.figa@samsung.com> References: <1404496099-26708-1-git-send-email-t.figa@samsung.com> <1404496099-26708-19-git-send-email-t.figa@samsung.com> Message-ID: <1405506268.4408.28.camel@x220> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2014-07-04 at 19:48 +0200, Tomasz Figa wrote: > After refactoring suspend/resume, which was last part with dependencies > on legacy code, all Kconfig symbols related to Samsung ATAGS support can > be deselected and more unused code removed. This includes most of s5p-* > code as well, as s5pv210 was their last user. > > Signed-off-by: Tomasz Figa > --- And I noticed another issue as this patch showed up in linux-next (this should be the last issue for this series). > [...] > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index f8185b5..1091b0a 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig >[...] > @@ -64,31 +51,6 @@ config SAMSUNG_ATAGS > > if SAMSUNG_ATAGS > > -# options for IRQ support > - > -config S5P_IRQ > - def_bool ARCH_S5PV210 > - help > - Support common interrupt part for ARCH_S5P SoCs > - > -config S5P_EXT_INT > - bool > - help > - Use the external interrupts (other than GPIO interrupts.) > - > -config S5P_GPIO_INT > - bool > - help > - Common code for the GPIO interrupts (other than external interrupts.) > - > -# options for gpio configuration support > - > -config S5P_GPIO_DRVSTR > - bool > - help > - Internal configuration to get and set correct GPIO driver strength > - helper > - This one is used (as a macro) in drivers/gpio/gpio-samsung.c. Is a patch that touches that macro queued somewhere? > config SAMSUNG_GPIO_EXTRA > int "Number of additional GPIO pins" > default 128 if SAMSUNG_GPIO_EXTRA128 Thanks, Paul Bolle