From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver Date: Mon, 21 Jul 2014 19:16:16 +0300 Message-ID: <1405959376.28520.3.camel@iivanov-dev> References: <1405610748-7583-1-git-send-email-iivanov@mm-sol.com> <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from ns.mm-sol.com ([37.157.136.199]:45141 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755332AbaGUQQj (ORCPT ); Mon, 21 Jul 2014 12:16:39 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: divya ojha Cc: Linus Walleij , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Bjorn Andersson , Mark Brown , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org On Mon, 2014-07-21 at 21:32 +0530, divya ojha wrote: > Hi, > > On Thu, Jul 17, 2014 at 8:55 PM, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > > > Signed-off-by: Ivan T. Ivanov > > --- > > drivers/pinctrl/Kconfig | 12 + > > drivers/pinctrl/Makefile | 1 + > > drivers/pinctrl/pinctrl-qpnp.c | 1565 +++++++++++++++++++++++++ > > include/dt-bindings/pinctrl/qcom,pm8xxx-mpp.h | 34 + > .. > + struct device *dev = qctrl->dev; > > + struct pinctrl_pin_desc *desc, *descs; > > + struct qpnp_padinfo *pad, *pads; > > + int idx, ret, cnt, gps, ais, aos, css; > > + const char **names, *format; > > + unsigned int addr; > > + > > + pads = devm_kcalloc(dev, qchip->npads, sizeof(*pads), GFP_KERNEL); > > when do we free these structures..? Good description could be found here[1]. Regards, Ivan [1] Documentation/driver-model/devres.txt