All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Vassili Karpov (malc)" <av1474@comtv.ru>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards
Date: Tue, 22 Jul 2014 09:28:55 +0200	[thread overview]
Message-ID: <1406014135-1192-1-git-send-email-kraxel@redhat.com> (raw)

This way the tests run without sound hardware being present
on the build machine.  Even with sound hardware it IMO isn't
very useful to use it in regression testing.  Once the sound
card tests are advanced enougth that they try to actually
play sound we probably want the guests sound output written
to a file (via QEMU_AUDIO_DRV=wav) rather than played on the
build machines sound hardware.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 tests/ac97-test.c      | 3 +++
 tests/es1370-test.c    | 3 +++
 tests/intel-hda-test.c | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/tests/ac97-test.c b/tests/ac97-test.c
index af30ea1..ba3be1a 100644
--- a/tests/ac97-test.c
+++ b/tests/ac97-test.c
@@ -8,6 +8,7 @@
  */
 
 #include <glib.h>
+#include <stdlib.h>
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
@@ -21,6 +22,8 @@ int main(int argc, char **argv)
 {
     int ret;
 
+    setenv("QEMU_AUDIO_DRV", "none", true);
+
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/ac97/nop", nop);
 
diff --git a/tests/es1370-test.c b/tests/es1370-test.c
index cc23fb5..d539ba3 100644
--- a/tests/es1370-test.c
+++ b/tests/es1370-test.c
@@ -8,6 +8,7 @@
  */
 
 #include <glib.h>
+#include <stdlib.h>
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
@@ -21,6 +22,8 @@ int main(int argc, char **argv)
 {
     int ret;
 
+    setenv("QEMU_AUDIO_DRV", "none", true);
+
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/es1370/nop", nop);
 
diff --git a/tests/intel-hda-test.c b/tests/intel-hda-test.c
index d89b407..32dc58f 100644
--- a/tests/intel-hda-test.c
+++ b/tests/intel-hda-test.c
@@ -8,6 +8,7 @@
  */
 
 #include <glib.h>
+#include <stdlib.h>
 #include <string.h>
 #include "libqtest.h"
 #include "qemu/osdep.h"
@@ -35,6 +36,8 @@ int main(int argc, char **argv)
 {
     int ret;
 
+    setenv("QEMU_AUDIO_DRV", "none", true);
+
     g_test_init(&argc, &argv, NULL);
     qtest_add_func("/intel-hda/ich6", ich6_test);
     qtest_add_func("/intel-hda/ich9", ich9_test);
-- 
1.8.3.1

             reply	other threads:[~2014-07-22  7:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  7:28 Gerd Hoffmann [this message]
2014-07-22 11:36 ` [Qemu-devel] [PATCH] tests: set QEMU_AUDIO_DRV=none for pci sound cards Markus Armbruster
2014-08-05 14:05   ` Markus Armbruster
2014-08-26  6:39     ` Gerd Hoffmann
2014-08-26 11:28       ` Markus Armbruster
2014-08-27 11:05       ` Stefan Hajnoczi
2014-08-05 14:23 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406014135-1192-1-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.