From: Nicholas Krause <xerofoify@gmail.com>
To: drbd-dev@lists.linbit.com
Cc: drbd-user@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: [PATCH] drbd: Remove fix me statements
Date: Tue, 22 Jul 2014 14:19:21 -0400 [thread overview]
Message-ID: <1406053161-5048-1-git-send-email-xerofoify@gmail.com> (raw)
This removes no longer needed fix me statements as the spinlocks
are needed to protect against other users of the list accessing
it when items on it are being moved off it.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/block/drbd/drbd_worker.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index d8f57b6..8793a32 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -1847,12 +1847,12 @@ static void wait_for_work(struct drbd_connection *connection, struct list_head *
int send_barrier;
prepare_to_wait(&connection->sender_work.q_wait, &wait, TASK_INTERRUPTIBLE);
spin_lock_irq(&connection->resource->req_lock);
- spin_lock(&connection->sender_work.q_lock); /* FIXME get rid of this one? */
+ spin_lock(&connection->sender_work.q_lock);
/* dequeue single item only,
* we still use drbd_queue_work_front() in some places */
if (!list_empty(&connection->sender_work.q))
list_move(connection->sender_work.q.next, work_list);
- spin_unlock(&connection->sender_work.q_lock); /* FIXME get rid of this one? */
+ spin_unlock(&connection->sender_work.q_lock);
if (!list_empty(work_list) || signal_pending(current)) {
spin_unlock_irq(&connection->resource->req_lock);
break;
--
1.9.1
next reply other threads:[~2014-07-22 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 18:19 Nicholas Krause [this message]
2014-07-23 12:27 ` [PATCH] drbd: Remove fix me statements Bjørn Mork
2014-07-23 15:45 ` Nick Krause
2014-07-23 17:33 ` Bjørn Mork
2014-07-23 19:13 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406053161-5048-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.