From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [Linaro-uefi] [PATCH V2 11/12] Add fdt_create_empty_tree() function. Date: Wed, 23 Jul 2014 10:58:33 +0100 Message-ID: <1406109513.1351.40.camel@kazak.uk.xensource.com> References: <1405989815-25236-1-git-send-email-roy.franz@linaro.org> <1405989815-25236-12-git-send-email-roy.franz@linaro.org> <53CE92F9.30709@linaro.org> <53CE9C14.8010808@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53CE9C14.8010808@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: keir , tim , xen-devel , Roy Franz , Stefano Stabellini , Jan Beulich , linaro-uefi List-Id: xen-devel@lists.xenproject.org On Tue, 2014-07-22 at 18:15 +0100, Julien Grall wrote: > On 07/22/2014 06:12 PM, Roy Franz wrote: > > On Tue, Jul 22, 2014 at 9:36 AM, Julien Grall wrote: > >> On 07/22/2014 01:43 AM, Roy Franz wrote: > >>> Add fdt_create_empty_tree() function from v1.4.0 of libfdt taken from > >>> git://git.jdl.com/software/dtc.git > >>> This function was not present in v1.3.0, but is a relatively simple > >>> helper function, and appears to work fine with the v1.3.0 that is > >>> currently present in XEN. > >> > >> Shouldn't we update our internal libfdt to v1.4.0 rather than taking > >> only the new file? > >> > >> Regards, > > > > I can certainly do that - I was simply being conservative. > > It's better to update the whole library to keep track of change. Ian, > Stefano, any thoughts? Updating the library would certainly be preferable if Roy is willing. > > Should I prepare an patch independent of the EFI stub series to > > just update the libfdt, or would you like it kept as part of the current > > series? > > I'm fine if you let the libfdt change in this series. Yeah, that's fine. Ian.