From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760781AbaGYO7Q (ORCPT ); Fri, 25 Jul 2014 10:59:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55744 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760737AbaGYO5A (ORCPT ); Fri, 25 Jul 2014 10:57:00 -0400 From: Jiri Olsa To: linux-kernel@vger.kernel.org Cc: Jiri Olsa , Arnaldo Carvalho de Melo , Corey Ashford , David Ahern , Frederic Weisbecker , Ingo Molnar , Jean Pihet , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: [PATCH 11/19] perf tools: Use list_move in ordered_events_delete function Date: Fri, 25 Jul 2014 16:56:09 +0200 Message-Id: <1406300177-31805-12-git-send-email-jolsa@kernel.org> In-Reply-To: <1406300177-31805-1-git-send-email-jolsa@kernel.org> References: <1406300177-31805-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Namhyung pointed out we can use list_move in ordered_events_delete. Suggested-by: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Jean Pihet Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra Signed-off-by: Jiri Olsa --- tools/perf/util/ordered-events.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-events.c index fb94f8b07515..ecdc9012cadd 100644 --- a/tools/perf/util/ordered-events.c +++ b/tools/perf/util/ordered-events.c @@ -96,8 +96,7 @@ ordered_events_new(struct ordered_events *oe, u64 timestamp) void ordered_events_delete(struct ordered_events *oe, struct ordered_event *event) { - list_del(&event->list); - list_add(&event->list, &oe->cache); + list_move(&event->list, &oe->cache); oe->nr_events--; } -- 1.8.3.1