From: Amir Vadai <amirv@mellanox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
netdev@vger.kernel.org, Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Ido Shamay <idos@mellanox.com>
Subject: [PATCH net-next V1 0/2] Helper to find length of headers in an ethernet frame
Date: Mon, 28 Jul 2014 14:27:59 +0300 [thread overview]
Message-ID: <1406546881-21863-1-git-send-email-amirv@mellanox.com> (raw)
Hi,
This patchset is based on the patch suggested by Eric Dumazet to calculate
header length of Ethernet headers using flow_dissector [1].
We have tested it in Mellanox lab, non GRO traffic shows some improvement in
bandwidth when using the patch, and anyway, the right way is to copy the exact
header and not just an arbitrary number of bytes.
Also tested using a built-in function (the orignal patch [2]). Eric's solution
gives the same numbers (even a bit better).
[1] - http://patchwork.ozlabs.org/patch/350413/
[2] - http://patchwork.ozlabs.org/patch/347031/
CC: Alexander Duyck <alexander.h.duyck@intel.com>
Changes from V0:
- Patch 2/2: net/mlx4_en: Copy exact header to SKB linear part
- Fixed commit message
- Added empty line after declaration
Amir Vadai (1):
net/mlx4_en: Copy exact header to SKB linear part
Eric Dumazet (1):
net: Header length compution function
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 14 +++++++++-----
include/linux/skbuff.h | 1 +
net/core/flow_dissector.c | 24 ++++++++++++++++++++++++
3 files changed, 34 insertions(+), 5 deletions(-)
--
1.8.3.4
next reply other threads:[~2014-07-28 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 11:27 Amir Vadai [this message]
2014-07-28 11:28 ` [PATCH net-next V1 1/2] net: Header length compution function Amir Vadai
2014-07-28 14:50 ` Alexander Duyck
2014-07-28 21:26 ` Cong Wang
2014-07-28 22:42 ` David Miller
2014-07-28 23:08 ` Alexander Duyck
2014-07-28 11:28 ` [PATCH net-next V1 2/2] net/mlx4_en: Copy exact header to SKB linear part Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406546881-21863-1-git-send-email-amirv@mellanox.com \
--to=amirv@mellanox.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.