From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH V2 10/12] add arm64 cache flushing code from
 linux
Date: Mon, 28 Jul 2014 17:24:26 +0100
Message-ID: <1406564666.15040.6.camel@kazak.uk.xensource.com>
References: <1405989815-25236-1-git-send-email-roy.franz@linaro.org>
	<1405989815-25236-11-git-send-email-roy.franz@linaro.org>
	<1406562836.17854.6.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1406562836.17854.6.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roy Franz <roy.franz@linaro.org>
Cc: keir@xen.org, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, linaro-uefi@lists.linaro.org, fu.wei@linaro.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-07-28 at 16:53 +0100, Ian Campbell wrote:
> On Mon, 2014-07-21 at 17:43 -0700, Roy Franz wrote:
> > +	.globl __flush_dcache_all
> > +__flush_dcache_all:
> 
> Please use GLOBAL().

Or rather ENTRY() in this case...

> 
> Other than that looks good (although I'm mostly taking it on trust that
> the Linux version of this isn't broken):
>         Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel