All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arianna Avanzini <avanzini.arianna@gmail.com>
To: xen-devel@lists.xen.org
Cc: Ian.Campbell@eu.citrix.com, paolo.valente@unimore.it,
	keir@xen.org, stefano.stabellini@eu.citrix.com,
	Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com,
	tim@xen.org, julien.grall@citrix.com, etrudeau@broadcom.com,
	andrew.cooper3@citrix.com, JBeulich@suse.com,
	avanzini.arianna@gmail.com, viktor.kleinik@globallogic.com
Subject: [PATCH v10 10/12] tools/libxl: move PCI-related macros in a header file
Date: Tue, 29 Jul 2014 00:12:07 +0200	[thread overview]
Message-ID: <1406585529-32193-11-git-send-email-avanzini.arianna@gmail.com> (raw)
In-Reply-To: <1406585529-32193-1-git-send-email-avanzini.arianna@gmail.com>

Currently, the PCI-related macro used by libxl are in the libxl_pci.c
source file. This commit moves them to a new libxl_pci.h header; such a
change is instrumental to the following commit, as it lets other libxl
source files be able to access the macros by including the header.

Signed-off-by: Arianna Avanzini <avanzini.arianna@gmail.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Paolo Valente <paolo.valente@unimore.it>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Eric Trudeau <etrudeau@broadcom.com>
Cc: Viktor Kleinik <viktor.kleinik@globallogic.com>
---
 tools/libxl/libxl_pci.c |  7 +------
 tools/libxl/libxl_pci.h | 10 ++++++++++
 2 files changed, 11 insertions(+), 6 deletions(-)
 create mode 100644 tools/libxl/libxl_pci.h

diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 2782d0e..21ecab1 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -17,12 +17,7 @@
 #include "libxl_osdeps.h" /* must come before any other headers */
 
 #include "libxl_internal.h"
-
-#define PCI_BDF                "%04x:%02x:%02x.%01x"
-#define PCI_BDF_SHORT          "%02x:%02x.%01x"
-#define PCI_BDF_VDEVFN         "%04x:%02x:%02x.%01x@%02x"
-#define PCI_OPTIONS            "msitranslate=%d,power_mgmt=%d"
-#define PCI_BDF_XSPATH         "%04x-%02x-%02x-%01x"
+#include "libxl_pci.h"
 
 static unsigned int pcidev_encode_bdf(libxl_device_pci *pcidev)
 {
diff --git a/tools/libxl/libxl_pci.h b/tools/libxl/libxl_pci.h
new file mode 100644
index 0000000..ed0e45a
--- /dev/null
+++ b/tools/libxl/libxl_pci.h
@@ -0,0 +1,10 @@
+#ifndef LIBXL_PCI_H
+#define LIBXL_PCI_H
+
+#define PCI_BDF                "%04x:%02x:%02x.%01x"
+#define PCI_BDF_SHORT          "%02x:%02x.%01x"
+#define PCI_BDF_VDEVFN         "%04x:%02x:%02x.%01x@%02x"
+#define PCI_OPTIONS            "msitranslate=%d,power_mgmt=%d"
+#define PCI_BDF_XSPATH         "%04x-%02x-%02x-%01x"
+
+#endif /* LIBXL_PCI_H */
-- 
2.0.3

  parent reply	other threads:[~2014-07-28 22:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 22:11 [PATCH v10 00/12] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Arianna Avanzini
2014-07-28 22:11 ` [PATCH v10 01/12] arch/arm: add consistency check to REMOVE p2m changes Arianna Avanzini
2014-07-29 11:55   ` Julien Grall
2014-07-29 12:01     ` Ian Campbell
2014-07-29 12:02     ` Andrew Cooper
2014-07-28 22:11 ` [PATCH v10 02/12] arch/arm: unmap partially-mapped I/O-memory regions Arianna Avanzini
2014-07-29 12:00   ` Julien Grall
2014-07-28 22:12 ` [PATCH v10 03/12] arch/x86: warn if to-be-removed mapping does not exist Arianna Avanzini
2014-07-28 22:12 ` [PATCH v10 04/12] arch/x86: cleanup memory_mapping DOMCTL Arianna Avanzini
2014-07-28 22:12 ` [PATCH v10 05/12] xen/common: add ARM stub for the function memory_type_changed() Arianna Avanzini
2014-07-28 22:12 ` [PATCH v10 06/12] xen/x86: factor out map and unmap from the memory_mapping DOMCTL Arianna Avanzini
2014-07-29  7:27   ` Jan Beulich
2014-07-29 12:02   ` Julien Grall
2014-07-28 22:12 ` [PATCH v10 07/12] xen/common: move the memory_mapping DOMCTL hypercall to common code Arianna Avanzini
2014-07-30 15:59   ` Julien Grall
2014-07-28 22:12 ` [PATCH v10 08/12] tools/libxl: parse optional start gfn from the iomem config option Arianna Avanzini
2014-08-04 13:39   ` Julien Grall
2014-07-28 22:12 ` [PATCH v10 09/12] tools/libxl: handle the iomem parameter with the memory_mapping hcall Arianna Avanzini
2014-07-28 22:12 ` Arianna Avanzini [this message]
2014-07-28 22:12 ` [PATCH v10 11/12] tools/libxl: explicitly grant access to needed I/O-memory ranges Arianna Avanzini
2014-07-30 11:33   ` Ian Campbell
2014-07-28 22:12 ` [PATCH v10 12/12] xen/common: do not implicitly permit access to mapped I/O memory Arianna Avanzini
2014-07-29  7:29   ` Jan Beulich
2014-08-18 19:50 ` [PATCH v10 00/12] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Andrii Tseglytskyi
2014-08-20 18:50   ` Arianna Avanzini
2014-08-20 19:15     ` Andrii Tseglytskyi
2014-08-21 15:43       ` Andrii Tseglytskyi
2014-08-22 14:25         ` Arianna Avanzini
2014-08-22 18:27           ` Andrii Tseglytskyi
2014-08-22 18:36             ` Arianna Avanzini
2014-08-22 19:31               ` Andrii Tseglytskyi
2014-08-22 23:51                 ` Stefano Stabellini
2014-08-23 12:07                   ` Arianna Avanzini
2014-08-23 17:36                     ` Andrii Tseglytskyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406585529-32193-11-git-send-email-avanzini.arianna@gmail.com \
    --to=avanzini.arianna@gmail.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=etrudeau@broadcom.com \
    --cc=julien.grall@citrix.com \
    --cc=keir@xen.org \
    --cc=paolo.valente@unimore.it \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=viktor.kleinik@globallogic.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.