From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDxWx-0000s8-MH for qemu-devel@nongnu.org; Sun, 03 Aug 2014 11:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDxWr-00013r-Ud for qemu-devel@nongnu.org; Sun, 03 Aug 2014 11:17:03 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDxWr-00013j-NZ for qemu-devel@nongnu.org; Sun, 03 Aug 2014 11:16:57 -0400 Message-ID: <1407079001.11008.17.camel@ori.omang.mine.nu> From: Knut Omang Date: Sun, 03 Aug 2014 17:16:41 +0200 In-Reply-To: References: <1406044070-25667-1-git-send-email-tamlokveer@gmail.com> <1406044070-25667-2-git-send-email-tamlokveer@gmail.com> <53D01B2D.2020107@weilnetz.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] intel-iommu: introduce Intel IOMMU (VT-d) emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Le Tan Cc: "Michael S. Tsirkin" , Stefan Weil , qemu-devel , Alex Williamson , Jan Kiszka , Anthony Liguori , Paolo Bonzini On Thu, 2014-07-24 at 07:24 +0800, Le Tan wrote: > Hi Stefan, > > 2014-07-24 4:29 GMT+08:00 Stefan Weil : > > Am 22.07.2014 17:47, schrieb Le Tan: > >> Add support for emulating Intel IOMMU according to the VT-d specification for > >> the q35 chipset machine. Implement the logic for DMAR (DMA remapping) without > >> PASID support. Use register-based invalidation for context-cache invalidation > >> and IOTLB invalidation. > >> Basic fault reporting and caching are not implemented yet. > >> > >> Signed-off-by: Le Tan > >> --- > >> hw/i386/Makefile.objs | 1 + > >> hw/i386/intel_iommu.c | 1139 +++++++++++++++++++++++++++++++++++++++++ > >> include/hw/i386/intel_iommu.h | 350 +++++++++++++ > >> 3 files changed, 1490 insertions(+) > >> create mode 100644 hw/i386/intel_iommu.c > >> create mode 100644 include/hw/i386/intel_iommu.h > >> > > [...] > >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >> new file mode 100644 > >> index 0000000..3ba0e1e > >> --- /dev/null > >> +++ b/hw/i386/intel_iommu.c > >> @@ -0,0 +1,1139 @@ > >> +/* > >> + * QEMU emulation of an Intel IOMMU (VT-d) > >> + * (DMA Remapping device) > >> + * > >> + * Copyright (c) 2013 Knut Omang, Oracle > >> + * Copyright (C) 2014 Le Tan, > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License as published by > >> + * the Free Software Foundation; either version 2 of the License, or > >> + * (at your option) any later version. > >> + > >> + * This program is distributed in the hope that it will be useful, > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + * GNU General Public License for more details. > >> + > >> + * You should have received a copy of the GNU General Public License > >> + * along with this program; if not, write to the Free Software > >> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > >> + */ > >> + > > > > I suggest replacing the FSF address here (and in other files) by the URL: > > > > * You should have received a copy of the GNU General Public License along > > * with this program; if not, see . > > > > This is the standard used for most GPL text in QEMU source files. > > Get it. I copied it from the Linux kernel tree. > Thanks very much! I have no problems with switching to the URL version of the license. Thanks for bringing this forward, Le! Knut