All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Kamil Debski <k.debski@samsung.com>,
	kernel@pengutronix.de, Philipp Zabel <p.zabel@pengutronix.de>
Subject: [PATCH 11/15] [media] coda: improve allocation error messages
Date: Tue,  5 Aug 2014 19:00:16 +0200	[thread overview]
Message-ID: <1407258020-12078-12-git-send-email-p.zabel@pengutronix.de> (raw)
In-Reply-To: <1407258020-12078-1-git-send-email-p.zabel@pengutronix.de>

Produce some error messages when internal buffer allocation
fails, for example because the CMA region is too small.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/media/platform/coda/coda-bit.c    | 4 +++-
 drivers/media/platform/coda/coda-common.c | 6 +++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/coda/coda-bit.c b/drivers/media/platform/coda/coda-bit.c
index fddd10d..529cc3e 100644
--- a/drivers/media/platform/coda/coda-bit.c
+++ b/drivers/media/platform/coda/coda-bit.c
@@ -1378,8 +1378,10 @@ static int __coda_start_decoding(struct coda_ctx *ctx)
 	}
 
 	ret = coda_alloc_framebuffers(ctx, q_data_dst, src_fourcc);
-	if (ret < 0)
+	if (ret < 0) {
+		v4l2_err(&dev->v4l2_dev, "failed to allocate framebuffers\n");
 		return ret;
+	}
 
 	/* Tell the decoder how many frame buffers we allocated. */
 	coda_write(dev, ctx->num_internal_frames, CODA_CMD_SET_FRAME_BUF_NUM);
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index 7311452..0f8a2c9 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -971,8 +971,12 @@ int coda_alloc_aux_buf(struct coda_dev *dev, struct coda_aux_buf *buf,
 {
 	buf->vaddr = dma_alloc_coherent(&dev->plat_dev->dev, size, &buf->paddr,
 					GFP_KERNEL);
-	if (!buf->vaddr)
+	if (!buf->vaddr) {
+		v4l2_err(&dev->v4l2_dev,
+			 "Failed to allocate %s buffer of size %u\n",
+			 name, size);
 		return -ENOMEM;
+	}
 
 	buf->size = size;
 
-- 
2.0.1


  parent reply	other threads:[~2014-08-05 17:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 17:00 [PATCH RESEND 00/15] CODA patches for v3.17 Philipp Zabel
2014-08-05 17:00 ` [PATCH 01/15] [media] coda: include header for memcpy Philipp Zabel
2014-08-05 17:00 ` [PATCH 02/15] [media] coda: move BIT specific functions into separate file Philipp Zabel
2014-08-05 17:00 ` [PATCH 03/15] [media] coda: remove unnecessary peek at next destination buffer from coda_finish_decode Philipp Zabel
2014-08-05 17:00 ` [PATCH 04/15] [media] coda: request BIT processor interrupt by name Philipp Zabel
2014-08-05 17:00 ` [PATCH 05/15] [media] coda: dequeue buffers if start_streaming fails Philipp Zabel
2014-08-05 17:00 ` [PATCH 06/15] [media] coda: dequeue buffers on streamoff Philipp Zabel
2014-08-05 17:00 ` [PATCH 07/15] [media] coda: skip calling coda_find_codec in encoder try_fmt_vid_out Philipp Zabel
2014-08-05 17:00 ` [PATCH 08/15] [media] coda: allow running coda without iram on mx6dl Philipp Zabel
2014-08-05 17:00 ` [PATCH 09/15] [media] coda: increase max vertical frame size to 1088 Philipp Zabel
2014-08-05 17:00 ` [PATCH 10/15] [media] coda: add an intermediate debug level Philipp Zabel
2014-08-05 17:00 ` Philipp Zabel [this message]
2014-08-05 17:00 ` [PATCH 12/15] [media] coda: fix timestamp list handling Philipp Zabel
2014-08-05 17:00 ` [PATCH 13/15] [media] coda: fix coda_s_fmt_vid_out Philipp Zabel
2014-08-05 17:00 ` [PATCH 14/15] [media] coda: set capture frame size with output S_FMT Philipp Zabel
2014-08-05 17:00 ` [PATCH 15/15] [media] coda: disable old cropping ioctls Philipp Zabel
2014-08-06 10:10 ` [PATCH RESEND 00/15] CODA patches for v3.17 Kamil Debski
2014-08-06 11:07   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407258020-12078-12-git-send-email-p.zabel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=k.debski@samsung.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.