From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?J=C3=BCrg=20Billeter?= Subject: [PATCH] IMSM: do not use comma expression for simple assignments Date: Wed, 6 Aug 2014 10:19:39 +0200 Message-ID: <1407313179-24598-1-git-send-email-j@bitron.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Sender: linux-raid-owner@vger.kernel.org To: NeilBrown Cc: linux-raid@vger.kernel.org, =?UTF-8?q?J=C3=BCrg=20Billeter?= List-Id: linux-raid.ids =46ixes build with gcc 4.9. error: right-hand operand of comma expression has no effect snprintf((char *) spare->sig, MAX_SIGNATURE_LENGTH, ^ Signed-off-by: J=C3=BCrg Billeter --- super-intel.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/super-intel.c b/super-intel.c index e28ac7d..f24d101 100644 --- a/super-intel.c +++ b/super-intel.c @@ -5069,13 +5069,13 @@ static int write_super_imsm_spares(struct intel= _super *super, int doclose) __u32 sum; struct dl *d; =20 - spare->mpb_size =3D __cpu_to_le32(sizeof(struct imsm_super)), - spare->generation_num =3D __cpu_to_le32(1UL), + spare->mpb_size =3D __cpu_to_le32(sizeof(struct imsm_super)); + spare->generation_num =3D __cpu_to_le32(1UL); spare->attributes =3D MPB_ATTRIB_CHECKSUM_VERIFY; - spare->num_disks =3D 1, - spare->num_raid_devs =3D 0, - spare->cache_size =3D mpb->cache_size, - spare->pwr_cycle_count =3D __cpu_to_le32(1), + spare->num_disks =3D 1; + spare->num_raid_devs =3D 0; + spare->cache_size =3D mpb->cache_size; + spare->pwr_cycle_count =3D __cpu_to_le32(1); =20 snprintf((char *) spare->sig, MAX_SIGNATURE_LENGTH, MPB_SIGNATURE MPB_VERSION_RAID0); --=20 2.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-raid" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html